You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2025/10/22 15:44:55 UTC
(arrow) branch main updated: GH-47909: [C++] Fix MSVC ARM64 build (#47910)
This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new a625340dc0 GH-47909: [C++] Fix MSVC ARM64 build (#47910)
a625340dc0 is described below
commit a625340dc0b9481b256944edab366e7a150a9e66
Author: Jonathan Giannuzzi <jg...@users.noreply.github.com>
AuthorDate: Wed Oct 22 18:44:48 2025 +0300
GH-47909: [C++] Fix MSVC ARM64 build (#47910)
### Rationale for this change
#47573 broke the Windows ARM64 MSVC build by trying to compile xsimd even when `ARROW_SIMD_LEVEL` is set to `NONE`.
### What changes are included in this PR?
Make sure that xsimd is only included when SIMD is requested.
### Are these changes tested?
Yes, in the Windows ARM64 MSVC build pipeline that I was developing on #47811 when I noticed the change.
### Are there any user-facing changes?
No.
* GitHub Issue: #47909
Authored-by: Jonathan Giannuzzi <jo...@giannuzzi.me>
Signed-off-by: Antoine Pitrou <an...@python.org>
---
cpp/src/arrow/util/bpacking_simd_default.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpp/src/arrow/util/bpacking_simd_default.cc b/cpp/src/arrow/util/bpacking_simd_default.cc
index 9be649f42c..60ca19c150 100644
--- a/cpp/src/arrow/util/bpacking_simd_default.cc
+++ b/cpp/src/arrow/util/bpacking_simd_default.cc
@@ -16,7 +16,9 @@
// under the License.
#include "arrow/util/bpacking_dispatch_internal.h"
-#include "arrow/util/bpacking_simd128_generated_internal.h"
+#if defined(ARROW_HAVE_NEON)
+# include "arrow/util/bpacking_simd128_generated_internal.h"
+#endif
#include "arrow/util/bpacking_simd_internal.h"
namespace arrow::internal {