[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2174: [KYUUBI #2029] Hive Backend Engine - Operation Logs

[GitBox <gi...@apache.org>]

KenjiFujima commented on a change in pull request #2174:
URL: https://github.com/apache/incubator-kyuubi/pull/2174#discussion_r831036697



##########
File path: externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/operation/ExecuteStatement.scala
##########
@@ -31,6 +32,11 @@ class ExecuteStatement(
     override val shouldRunAsync: Boolean,
     queryTimeout: Long)
   extends HiveOperation(OperationType.EXECUTE_STATEMENT, session) {
+
+  private val operationLog: OperationLog = OperationLog.createOperationLog(session, getHandle)

Review comment:
       @yaooqinn, I'm confusing about whether the `Log4j12DivertAppender` needs the operation. The operation log is used for setting the current operation log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org