You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "lukaszzborek (via GitHub)" <gi...@apache.org> on 2025/12/28 11:43:18 UTC
[PR] feat(csharp): add iggy error status codes [iggy]
lukaszzborek opened a new pull request, #2519:
URL: https://github.com/apache/iggy/pull/2519
- add `IggyErrorCode` enum definition
- change `IggyInvalidStatusCodeException` to contains `IggyErrorCode`
- add tool to generate enum values from rust error file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp): add iggy error status codes [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex commented on PR #2519:
URL: https://github.com/apache/iggy/pull/2519#issuecomment-3698780349
Hi, I've looked through the PR and I really like the idea, but there is one problem tho...
Currently `IggyError` isn't versioned (e.g it's not an separate crate that adheres to any sane versioning standards), which means that we might change it as we wish (move/remove it, etc..), which means that on an arbitrary release (non major one), we could potentially break the C# SDK.
Since the idea is great, I would like to archive this PR and revisit it once we figure out how to extract our error into an dedicated crate, that we can version independently.
Created #2524 to address that problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp): add iggy error status codes [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2519: feat(csharp): add iggy error status codes
URL: https://github.com/apache/iggy/pull/2519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp): add iggy error status codes [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2519:
URL: https://github.com/apache/iggy/pull/2519#issuecomment-3900298557
This pull request was automatically closed because it has been inactive for 14 days. Feel free to reopen it if you'd like to continue working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp): add iggy error status codes [iggy]
Posted by "lukaszzborek (via GitHub)" <gi...@apache.org>.
lukaszzborek commented on PR #2519:
URL: https://github.com/apache/iggy/pull/2519#issuecomment-3699017678
yep, it might be good idea for hold on it to time where will be separate crate for IggyError. It can be a bit confusing where error code will change in server.
We can also think about some CI checks for thats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp): add iggy error status codes [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2519:
URL: https://github.com/apache/iggy/pull/2519#issuecomment-3824720399
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.
If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.
Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp): add iggy error status codes [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2519:
URL: https://github.com/apache/iggy/pull/2519#issuecomment-3863157185
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.
If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.
Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org