You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/07/10 09:02:04 UTC

[jira] [Updated] (HADOOP-12199) Optimize find_changed_modules

     [ https://issues.apache.org/jira/browse/HADOOP-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kengo Seki updated HADOOP-12199:
--------------------------------
    Attachment: HADOOP-12199.HADOOP-12111.01.patch

Attaching a patch. Debug output before this patch applied:

{code}
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configurable.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configured.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Reconfigurable.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationException.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationTaskStatus.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationUtil.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/package.html...
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:51:30 UTC 2015 DEBUG]: Running precheck_without_patch
{code}

After:

{code}
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configurable.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configured.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Reconfigurable.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationException.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationTaskStatus.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationUtil.java...
Checking patch hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/package.html...
[Fri Jul 10 06:52:09 UTC 2015 DEBUG]: Find pom.xml dir for: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf
[Fri Jul 10 06:52:09 UTC 2015 DEBUG]: Found: hadoop-common-project/hadoop-common
[Fri Jul 10 06:52:09 UTC 2015 DEBUG]: Running precheck_without_patch
{code}

> Optimize find_changed_modules
> -----------------------------
>
>                 Key: HADOOP-12199
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12199
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>            Reporter: Allen Wittenauer
>            Priority: Trivial
>         Attachments: HADOOP-12199.HADOOP-12111.01.patch
>
>
> I think it might be possible to optimize find_changed_modules by stripping the file names and uniq'ing the directories prior to trying to find the pom.xml / build.xml .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)