[PATCH] enable mod_so by default [Was: DSO]

[Aaron Bannert <aa...@clove.org>]

On Tue, Oct 09, 2001 at 07:15:26AM -0400, Jeff Trawick wrote:
> It sounds reasonable to me to build mod_so by default, but I think
> that the builder should be able to turn off mod_so.
> 
> Somebody putting together a package for distribution/support ought to
> be able to decide what modules they are willing to deal with, and
> mod_so opens up everything.  I doubt that a commercial vendor would
> make such a decision, but certainly within an organization it might
> make sense.  I bet a lot of companies would like a build of IIS to
> put on their employees' machines which could not be made to do
> anything other than serve static pages :)

I think this patch would do that. One should be able to do --disable-so
to turn it off, and by default it will be built.

My only worry is that this will break out-of-the-box builds for platforms
that aren't supported under apr_dso.h. Are any of our apache-supported
platforms not supported under apr_dso.h?

-aaron


Index: modules/mappers/config9.m4
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/mappers/config9.m4,v
retrieving revision 1.5
diff -u -r1.5 config9.m4
--- modules/mappers/config9.m4	2001/10/03 17:47:51	1.5
+++ modules/mappers/config9.m4	2001/10/09 17:48:21
@@ -17,11 +17,8 @@
   APR_ADDTO(CFLAGS,-DNO_DBM_REWRITEMAP)
 ])
 
-if test "$sharedobjs" = "yes"; then
-    APACHE_MODULE(so, DSO capability, , , static)
-else
-    APACHE_MODULE(so, DSO capability, , , no)
-fi
+APACHE_MODULE(so, DSO capability, , , static)
+
 dnl ### why save the cache?
 AC_CACHE_SAVE
 

Re: [PATCH] enable mod_so by default [Was: DSO]

[Justin Erenkrantz <je...@ebuilt.com>]

On Tue, Oct 09, 2001 at 10:55:44AM -0700, Aaron Bannert wrote:
> I think this patch would do that. One should be able to do --disable-so
> to turn it off, and by default it will be built.
> 
> My only worry is that this will break out-of-the-box builds for platforms
> that aren't supported under apr_dso.h. Are any of our apache-supported
> platforms not supported under apr_dso.h?

Committed with an additional APR_HAS_DSO check which should resolve
the above concern.  Please verify that I didn't do something 
stupid.  =)

Thanks.  -- justin

Re: [PATCH] enable mod_so by default [Was: DSO]

[Cliff Woolley <cl...@yahoo.com>]

On Tue, 9 Oct 2001, Aaron Bannert wrote:

> I think this patch would do that. One should be able to do --disable-so
> to turn it off, and by default it will be built.
>
> My only worry is that this will break out-of-the-box builds for platforms
> that aren't supported under apr_dso.h. Are any of our apache-supported
> platforms not supported under apr_dso.h?

-0 ... I think the minimal default build should be a set of modules that
can be considered tight, reliable, and secure.  mod_so doesn't fit that
bill IMO, not because of its implementation but just the whole loadable
module concept.  Maybe that's just me, but I doubt it...

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA