[GitHub] [hadoop] tomscut commented on a diff in pull request #4448: HDFS-16634. Dynamically adjust slow peer report size on JMX metrics

[GitBox <gi...@apache.org>]

tomscut commented on code in PR #4448:
URL: https://github.com/apache/hadoop/pull/4448#discussion_r900424477


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerTracker.java:
##########
@@ -80,7 +80,7 @@ public class SlowPeerTracker {
    * Number of nodes to include in JSON report. We will return nodes with
    * the highest number of votes from peers.
    */
-  private final int maxNodesToReport;
+  private int maxNodesToReport;

Review Comment:
   Please set this to `volatile`. Although it doesn't make a big difference here, I think it's better to be consistent with other reconfig changes. What do you think of this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org