You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by Owen O'Malley <om...@apache.org> on 2017/01/31 17:06:44 UTC
[VOTE] Should we release ORC-1.3.1rc0?
All,
We have a couple of bug fixes that have gone in and I think we should
make a release.
Fixes:
* ORC-134 DecimalColumnStatistics throws NPE when all column values are
null.
* ORC-100 Make findbugs a mandatory part of the build and fixed all of the
current warnings.
* ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
for decimal.
The other one that is pending is ORC-135 (predicate pushdown for timestamp
is sensitive to
changing timezones) is important, but I want to be really careful with that
one since it is a
larger change. I'm in the middle of reviewing that one and that one is a
lot riskier change.
.. Owen
Re: [VOTE] Should we release ORC-1.3.1rc0?
Posted by Owen O'Malley <om...@apache.org>.
With three +1's and no -1's, the vote passes. I'll finalize the release.
Thanks, Alan and Prasanth!
.. Owen
On Thu, Feb 2, 2017 at 11:29 AM, Alan Gates <al...@gmail.com> wrote:
> +1. Checked the signatures, did a build on centos 7.
>
> Alan.
>
> > On Feb 1, 2017, at 1:26 PM, Owen O'Malley <om...@apache.org> wrote:
> >
> > I forgot to include the links:
> >
> > tarball: http://home.apache.org/~omalley/orc-1.3.1rc0/
> > tag: https://github.com/apache/orc/releases/tag/release-1.3.1rc0
> >
> > .. Owen
> >
> > On Wed, Feb 1, 2017 at 11:15 AM, Alan Gates <al...@gmail.com>
> wrote:
> >
> >> I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and
> >> ORC-138. I don't have enough information to make a call on the risk vs
> >> reward for ORC-135.
> >>
> >> Alan.
> >>
> >>> On Jan 31, 2017, at 9:06 AM, Owen O'Malley <om...@apache.org> wrote:
> >>>
> >>> All,
> >>> We have a couple of bug fixes that have gone in and I think we should
> >>> make a release.
> >>>
> >>> Fixes:
> >>> * ORC-134 DecimalColumnStatistics throws NPE when all column values are
> >>> null.
> >>> * ORC-100 Make findbugs a mandatory part of the build and fixed all of
> >> the
> >>> current warnings.
> >>> * ORC-138 Fix forward port of HIVE-15335 that messed up schema
> evolution
> >>> for decimal.
> >>>
> >>> The other one that is pending is ORC-135 (predicate pushdown for
> >> timestamp
> >>> is sensitive to
> >>> changing timezones) is important, but I want to be really careful with
> >> that
> >>> one since it is a
> >>> larger change. I'm in the middle of reviewing that one and that one is
> a
> >>> lot riskier change.
> >>>
> >>> .. Owen
> >>
> >>
>
>
Re: [VOTE] Should we release ORC-1.3.1rc0?
Posted by Alan Gates <al...@gmail.com>.
+1. Checked the signatures, did a build on centos 7.
Alan.
> On Feb 1, 2017, at 1:26 PM, Owen O'Malley <om...@apache.org> wrote:
>
> I forgot to include the links:
>
> tarball: http://home.apache.org/~omalley/orc-1.3.1rc0/
> tag: https://github.com/apache/orc/releases/tag/release-1.3.1rc0
>
> .. Owen
>
> On Wed, Feb 1, 2017 at 11:15 AM, Alan Gates <al...@gmail.com> wrote:
>
>> I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and
>> ORC-138. I don't have enough information to make a call on the risk vs
>> reward for ORC-135.
>>
>> Alan.
>>
>>> On Jan 31, 2017, at 9:06 AM, Owen O'Malley <om...@apache.org> wrote:
>>>
>>> All,
>>> We have a couple of bug fixes that have gone in and I think we should
>>> make a release.
>>>
>>> Fixes:
>>> * ORC-134 DecimalColumnStatistics throws NPE when all column values are
>>> null.
>>> * ORC-100 Make findbugs a mandatory part of the build and fixed all of
>> the
>>> current warnings.
>>> * ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
>>> for decimal.
>>>
>>> The other one that is pending is ORC-135 (predicate pushdown for
>> timestamp
>>> is sensitive to
>>> changing timezones) is important, but I want to be really careful with
>> that
>>> one since it is a
>>> larger change. I'm in the middle of reviewing that one and that one is a
>>> lot riskier change.
>>>
>>> .. Owen
>>
>>
Re: [VOTE] Should we release ORC-1.3.1rc0?
Posted by Owen O'Malley <om...@apache.org>.
I forgot to include the links:
tarball: http://home.apache.org/~omalley/orc-1.3.1rc0/
tag: https://github.com/apache/orc/releases/tag/release-1.3.1rc0
.. Owen
On Wed, Feb 1, 2017 at 11:15 AM, Alan Gates <al...@gmail.com> wrote:
> I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and
> ORC-138. I don't have enough information to make a call on the risk vs
> reward for ORC-135.
>
> Alan.
>
> > On Jan 31, 2017, at 9:06 AM, Owen O'Malley <om...@apache.org> wrote:
> >
> > All,
> > We have a couple of bug fixes that have gone in and I think we should
> > make a release.
> >
> > Fixes:
> > * ORC-134 DecimalColumnStatistics throws NPE when all column values are
> > null.
> > * ORC-100 Make findbugs a mandatory part of the build and fixed all of
> the
> > current warnings.
> > * ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
> > for decimal.
> >
> > The other one that is pending is ORC-135 (predicate pushdown for
> timestamp
> > is sensitive to
> > changing timezones) is important, but I want to be really careful with
> that
> > one since it is a
> > larger change. I'm in the middle of reviewing that one and that one is a
> > lot riskier change.
> >
> > .. Owen
>
>
Re: [VOTE] Should we release ORC-1.3.1rc0?
Posted by Prasanth Jayachandran <j....@gmail.com>.
+1 for 1.3.1rc0 release artifacts
- Verified checksums, signature and ran rat check
- Built from source and ran unit tests on Mac OS X
Thanks and Regards,
Prasanth Jayachandran
On Wed, Feb 1, 2017 at 1:27 PM, Prasanth Jayachandran <
j.prasanth.j@gmail.com> wrote:
> +1 on the release.
>
> Although I still feel ORC-135 is important as the default behaviour (PPD
> on) can return incorrect results for timestamp columns. Maybe we can roll
> another quick release after 1.3.1 with ORC-135. This would need backport to
> 1.2.x that disables PPD on timestamp columns (ORC-137).
>
>
> Thanks and Regards,
> Prasanth Jayachandran
>
>
> On Wed, Feb 1, 2017 at 11:15 AM, Alan Gates <al...@gmail.com> wrote:
>
>> I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and
>> ORC-138. I don't have enough information to make a call on the risk vs
>> reward for ORC-135.
>>
>> Alan.
>>
>> > On Jan 31, 2017, at 9:06 AM, Owen O'Malley <om...@apache.org> wrote:
>> >
>> > All,
>> > We have a couple of bug fixes that have gone in and I think we should
>> > make a release.
>> >
>> > Fixes:
>> > * ORC-134 DecimalColumnStatistics throws NPE when all column values are
>> > null.
>> > * ORC-100 Make findbugs a mandatory part of the build and fixed all of
>> the
>> > current warnings.
>> > * ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
>> > for decimal.
>> >
>> > The other one that is pending is ORC-135 (predicate pushdown for
>> timestamp
>> > is sensitive to
>> > changing timezones) is important, but I want to be really careful with
>> that
>> > one since it is a
>> > larger change. I'm in the middle of reviewing that one and that one is a
>> > lot riskier change.
>> >
>> > .. Owen
>>
>>
>
Re: [VOTE] Should we release ORC-1.3.1rc0?
Posted by Prasanth Jayachandran <j....@gmail.com>.
+1 on the release.
Although I still feel ORC-135 is important as the default behaviour (PPD
on) can return incorrect results for timestamp columns. Maybe we can roll
another quick release after 1.3.1 with ORC-135. This would need backport to
1.2.x that disables PPD on timestamp columns (ORC-137).
Thanks and Regards,
Prasanth Jayachandran
On Wed, Feb 1, 2017 at 11:15 AM, Alan Gates <al...@gmail.com> wrote:
> I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and
> ORC-138. I don't have enough information to make a call on the risk vs
> reward for ORC-135.
>
> Alan.
>
> > On Jan 31, 2017, at 9:06 AM, Owen O'Malley <om...@apache.org> wrote:
> >
> > All,
> > We have a couple of bug fixes that have gone in and I think we should
> > make a release.
> >
> > Fixes:
> > * ORC-134 DecimalColumnStatistics throws NPE when all column values are
> > null.
> > * ORC-100 Make findbugs a mandatory part of the build and fixed all of
> the
> > current warnings.
> > * ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
> > for decimal.
> >
> > The other one that is pending is ORC-135 (predicate pushdown for
> timestamp
> > is sensitive to
> > changing timezones) is important, but I want to be really careful with
> that
> > one since it is a
> > larger change. I'm in the middle of reviewing that one and that one is a
> > lot riskier change.
> >
> > .. Owen
>
>
Re: [VOTE] Should we release ORC-1.3.1rc0?
Posted by Alan Gates <al...@gmail.com>.
I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and ORC-138. I don't have enough information to make a call on the risk vs reward for ORC-135.
Alan.
> On Jan 31, 2017, at 9:06 AM, Owen O'Malley <om...@apache.org> wrote:
>
> All,
> We have a couple of bug fixes that have gone in and I think we should
> make a release.
>
> Fixes:
> * ORC-134 DecimalColumnStatistics throws NPE when all column values are
> null.
> * ORC-100 Make findbugs a mandatory part of the build and fixed all of the
> current warnings.
> * ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
> for decimal.
>
> The other one that is pending is ORC-135 (predicate pushdown for timestamp
> is sensitive to
> changing timezones) is important, but I want to be really careful with that
> one since it is a
> larger change. I'm in the middle of reviewing that one and that one is a
> lot riskier change.
>
> .. Owen