You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2023/04/28 14:49:16 UTC
[GitHub] [iceberg] nastra commented on a diff in pull request #7233: Add outputFile() method for FileAppender
nastra commented on code in PR #7233:
URL: https://github.com/apache/iceberg/pull/7233#discussion_r1180506529
##########
.palantir/revapi.yml:
##########
@@ -413,6 +413,9 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.lang.String org.apache.iceberg.view.ViewVersion::operation()"
justification: "Add operation API to view version"
+ - code: "java.method.addedToInterface"
Review Comment:
we generally try to avoid breaking the API. What we typically do in such a case is adding a `default` method that throws an `UnsupportedOperationException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org