You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2009/11/09 10:48:33 UTC
[jira] Created: (HAMA-225) Jacobi iteration is in a infinite loop
Jacobi iteration is in a infinite loop
--------------------------------------
Key: HAMA-225
URL: https://issues.apache.org/jira/browse/HAMA-225
Project: Hama
Issue Type: Bug
Components: matrix
Affects Versions: 0.2.0, 0.1.0
Reporter: Edward J. Yoon
Assignee: Edward J. Yoon
Fix For: 0.2.0, 0.1.0
while (state != 0 && loops > icount) {
should be changed as
while (state != 0 && icount < loops) {
and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-225:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I don't see any problem. I just committed this.
If you find any problem, please let me know.
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_0.19.patch, HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > 0) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-225:
--------------------------------
Attachment: HAMA-225_trunk.patch
Attach my patch.
when the pivot_row/col is zero, iteration should be stopped.
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > icount) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-225:
--------------------------------
Description:
while (state != 0 && loops > 0) {
should be changed as
while (state != 0 && icount < loops) {
and, value of state seems not changed. There is also a bug.
was:
while (state != 0 && loops > icount) {
should be changed as
while (state != 0 && icount < loops) {
and, value of state seems not changed. There is also a bug.
fix my typos
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_0.19.patch, HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > 0) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-225:
--------------------------------
Attachment: HAMA-225_0.19.patch
attach patch for 0.19
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_0.19.patch, HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > icount) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775315#action_12775315 ]
Edward J. Yoon commented on HAMA-225:
-------------------------------------
@Samuel, Could you review this?
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_0.19.patch, HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > icount) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-225:
--------------------------------
Status: Patch Available (was: Open)
Submit patch to hudson.
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > icount) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775309#action_12775309 ]
Hudson commented on HAMA-225:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12424437/HAMA-225_trunk.patch
against trunk revision 833997.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 6 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/213/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/213/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/213/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/213/console
This message is automatically generated.
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_0.19.patch, HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > icount) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-225) Jacobi iteration is in a infinite loop
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775307#action_12775307 ]
Edward J. Yoon commented on HAMA-225:
-------------------------------------
>> while (state != 0 && loops > icount) {
>> should be changed as
>> while (state != 0 && icount < loops) {
there was a code for discount of loops. it's not a point.
> Jacobi iteration is in a infinite loop
> --------------------------------------
>
> Key: HAMA-225
> URL: https://issues.apache.org/jira/browse/HAMA-225
> Project: Hama
> Issue Type: Bug
> Components: matrix
> Affects Versions: 0.2.0, 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0, 0.1.0
>
> Attachments: HAMA-225_0.19.patch, HAMA-225_trunk.patch
>
>
> while (state != 0 && loops > icount) {
> should be changed as
> while (state != 0 && icount < loops) {
> and, value of state seems not changed. There is also a bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.