You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/03/04 21:27:00 UTC
[jira] [Work logged] (HDDS-1193) Refactor ContainerChillModeRule
and DatanodeChillMode rule
[ https://issues.apache.org/jira/browse/HDDS-1193?focusedWorklogId=207438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207438 ]
ASF GitHub Bot logged work on HDDS-1193:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/19 21:26
Start Date: 04/Mar/19 21:26
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #534: HDDS-1193. Refactor ContainerChillModeRule and DatanodeChillMode rule.
URL: https://github.com/apache/hadoop/pull/534#discussion_r262249732
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ContainerChillModeRule.java
##########
@@ -84,10 +84,6 @@ public double getCurrentContainerThreshold() {
@Override
public void process(NodeRegistrationContainerReport reportsProto) {
- if (maxContainer == 0) {
Review comment:
In validate(), we call getCurrentContainerThreshold(),
```
public double getCurrentContainerThreshold() {
if (maxContainer == 0) {
return 1;
}
return (containerWithMinReplicas.doubleValue() / maxContainer);
}
public boolean validate() {
return getCurrentContainerThreshold() >= chillModeCutoff;
}
```
So, if maxContainer=0, in validate() call, we get 1 from getCurrentContainerThreshold() and do >= check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 207438)
Time Spent: 20m (was: 10m)
> Refactor ContainerChillModeRule and DatanodeChillMode rule
> ----------------------------------------------------------
>
> Key: HDDS-1193
> URL: https://issues.apache.org/jira/browse/HDDS-1193
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The main intention of this Jira is to have all rules look in a similar way of handling events.
> In this Jira, did the following changes:
> # Both DatanodeRule and ContainerRule implements EventHandler and listen for NodeRegistrationContainerReport
> # Update ScmChillModeManager not to handle any events. (As each rule need to handle an event, and work on that rule)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org