You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/06 01:36:22 UTC
[GitHub] [incubator-echarts] plainheart opened a new pull request #12568: fix(bmap): tweak BMapView.js, no need to import `clone` from zrender and it can be fetched from echarts object.
plainheart opened a new pull request #12568:
URL: https://github.com/apache/incubator-echarts/pull/12568
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
We know the function `clone` in `zrender` is equals to the function `clone` in `echarts.util`.
Therefore, there is no need to import `clone` from zrender and it can be fetched from echarts object.
This fixing will reduce unnecessary imports and minimize the size of distribution file.
## Details
### Before: What was the problem?
Redundant imports will be packaged into the final distribution file
### After: How is it fixed in this PR?
Use `echarts.util.clone` instead.
### Related commits
Refer to this commit https://github.com/apache/incubator-echarts/commit/defffbe9779ae04d81e5a54f4a27b73e140ecc16 about `extension-src/bmap/BMapView.js`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12568: fix(bmap): tweak BMapView.js, no need to import `clone` from zrender and it can be fetched from echarts object.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12568:
URL: https://github.com/apache/incubator-echarts/pull/12568#issuecomment-624399049
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org