You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2017/10/23 14:05:45 UTC
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the root cause is the test is waiting for the wrong config to propagate (that was already written earlier) so it never waits.
I've run this several times and am not seeing the failure anymore but will continue to run more tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #813
----
commit c291a9c66a65027ce7cfa5cd4ce9768dff30b644
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T14:03:04Z
fixed assertEventually to wait on broTest config propagation
----
---
[GitHub] metron issue #813: METRON-1274: Master has failure in StormControllerIntegra...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/813
Fixed the other failure at `SensorParserConfigControllerIntegrationTest.test:294`.
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the root cause is the test is waiting for the wrong config to propagate (that was already written earlier) so it never waits.
I've run this several times and am not seeing the failure anymore but will continue to run more tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #813
----
----
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
[GitHub] metron issue #813: METRON-1274: Master has failure in StormControllerIntegra...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/813
Awesome work, @merrimanr Have this get through 5 runs in travis and I'm +1.
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the root cause is the test is waiting for the wrong config to propagate (that was already written earlier) so it never waits.
I've run this several times and am not seeing the failure anymore but will continue to run more tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #813
----
commit c291a9c66a65027ce7cfa5cd4ce9768dff30b644
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T14:03:04Z
fixed assertEventually to wait on broTest config propagation
commit c63b9d98cdf2317811d05640249cfe13ecd7b40d
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T22:41:12Z
fixed assertEventually in SensorParserConfigControllerIntegrationTest
----
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the root cause is the test is waiting for the wrong config to propagate (that was already written earlier) so it never waits.
I've run this several times and am not seeing the failure anymore but will continue to run more tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #813
----
commit c291a9c66a65027ce7cfa5cd4ce9768dff30b644
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T14:03:04Z
fixed assertEventually to wait on broTest config propagation
commit c63b9d98cdf2317811d05640249cfe13ecd7b40d
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T22:41:12Z
fixed assertEventually in SensorParserConfigControllerIntegrationTest
----
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/813
---
[GitHub] metron issue #813: METRON-1274: Master has failure in StormControllerIntegra...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/813
Could you also add an `assertEventually` to `SensorParserConfigControllerIntegrationTest.test:294` ? Looks like it also failed in https://travis-ci.org/apache/metron/builds/290806887
Also, we'll want to rerun these in travis a number of times since they're intermittent.
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the root cause is the test is waiting for the wrong config to propagate (that was already written earlier) so it never waits.
I've run this several times and am not seeing the failure anymore but will continue to run more tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #813
----
commit c291a9c66a65027ce7cfa5cd4ce9768dff30b644
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T14:03:04Z
fixed assertEventually to wait on broTest config propagation
commit c63b9d98cdf2317811d05640249cfe13ecd7b40d
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T22:41:12Z
fixed assertEventually in SensorParserConfigControllerIntegrationTest
----
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the root cause is the test is waiting for the wrong config to propagate (that was already written earlier) so it never waits.
I've run this several times and am not seeing the failure anymore but will continue to run more tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #813
----
commit c291a9c66a65027ce7cfa5cd4ce9768dff30b644
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T14:03:04Z
fixed assertEventually to wait on broTest config propagation
commit c63b9d98cdf2317811d05640249cfe13ecd7b40d
Author: merrimanr <me...@gmail.com>
Date: 2017-10-23T22:41:12Z
fixed assertEventually in SensorParserConfigControllerIntegrationTest
----
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/813#discussion_r146276684
--- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java ---
@@ -187,9 +187,9 @@ public void test() throws Exception {
sensorParserConfig.setSensorTopic("broTest");
sensorParserConfigService.save(sensorParserConfig);
{
- final Map<String, Object> expectedGlobalConfig = globalConfig;
+ final SensorParserConfig expectedSensorParserConfig = sensorParserConfig;
//we must wait for the config to find its way into the config.
- TestUtils.assertEventually(() -> Assert.assertEquals(expectedGlobalConfig, globalConfigService.get()));
+ TestUtils.assertEventually(() -> Assert.assertEquals(expectedSensorParserConfig, sensorParserConfigService.findOne("broTest")));
--- End diff --
oh crap, that's not even a legit assertion. I'm embarassed now ;)
---