You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Carlin Rogers (JIRA)" <de...@beehive.apache.org> on 2006/08/30 00:20:22 UTC

[jira] Created: (BEEHIVE-1142) PageFlowViewHandler.renderView() needs to check request type before casting to HttpServletRequest

PageFlowViewHandler.renderView() needs to check request type before casting to HttpServletRequest
-------------------------------------------------------------------------------------------------

                 Key: BEEHIVE-1142
                 URL: http://issues.apache.org/jira/browse/BEEHIVE-1142
             Project: Beehive
          Issue Type: Bug
    Affects Versions: 1.0.1, v.next
            Reporter: Carlin Rogers
         Assigned To: Carlin Rogers
             Fix For: v.next


As with the other methods in PageFlowViewHandler, the method renderView() should check that the request is an instance of HttpServletRequest. At the moment, renderView() is being unconditionally cast to an HttpServletRequest. This can cause a ClassCastException. The result of getRequest() is of Object type and can legally be something other than an HttpServletRequest (such as in the case of a JSR 168 JSF bridge, where it is a RenderRequest).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (BEEHIVE-1142) PageFlowViewHandler.renderView() needs to check request type before casting to HttpServletRequest

Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-1142?page=all ]

Carlin Rogers resolved BEEHIVE-1142.
------------------------------------

    Resolution: Fixed

fixed with SVN revision 438282

http://svn.apache.org/viewvc?rev=438282&view=rev

> PageFlowViewHandler.renderView() needs to check request type before casting to HttpServletRequest
> -------------------------------------------------------------------------------------------------
>
>                 Key: BEEHIVE-1142
>                 URL: http://issues.apache.org/jira/browse/BEEHIVE-1142
>             Project: Beehive
>          Issue Type: Bug
>    Affects Versions: 1.0.1, v.next
>            Reporter: Carlin Rogers
>         Assigned To: Carlin Rogers
>             Fix For: v.next
>
>
> As with the other methods in PageFlowViewHandler, the method renderView() should check that the request is an instance of HttpServletRequest. At the moment, renderView() is being unconditionally cast to an HttpServletRequest. This can cause a ClassCastException. The result of getRequest() is of Object type and can legally be something other than an HttpServletRequest (such as in the case of a JSR 168 JSF bridge, where it is a RenderRequest).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira