You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2007/04/13 22:39:15 UTC
[jira] Created: (WSCOMMONS-194) SOAPEnvelope getHeader processing
SOAPEnvelope getHeader processing
---------------------------------
Key: WSCOMMONS-194
URL: https://issues.apache.org/jira/browse/WSCOMMONS-194
Project: WS-Commons
Issue Type: Bug
Reporter: Rich Scheuerle
There are a few fundamental problems in the header processing in SOAPEnvelopeImpl
1) The getHeader method sometimes adds missing header elements and sometimes it does not. This violates the javadoc for the method and is the kind of random behavior that should be avoided. (In addition, when the current code adds a header it causes a full expansion of the om tree.)
2) The SOAPEnvelopeImpl.addChild method is improved to consider the parser state when adding the header. In the current code it is possible that this method will add the header twice, or add the header after the body.
(!) I also discovered that searching for missing headers can also cause the full expansion of the om tree. The culprit in such cases was the misuse of the getElementByName method. But I see that these errors have already been fixed in the current version of the code. (Thank you to the kind soul who discovered this already !)
I have run all of the axiom and axis2 tests with my new changes, which I will be adding shortly.
These changes were found by the IBM Performance Analysist team. Special thanks to David Strite for detecting the om expansion problem!
Thanks,
Rich
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Resolved: (WSCOMMONS-194) SOAPEnvelope getHeader processing
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rich Scheuerle resolved WSCOMMONS-194.
--------------------------------------
Resolution: Fixed
This problem is fixed.
> SOAPEnvelope getHeader processing
> ---------------------------------
>
> Key: WSCOMMONS-194
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-194
> Project: WS-Commons
> Issue Type: Bug
> Reporter: Rich Scheuerle
>
> There are a few fundamental problems in the header processing in SOAPEnvelopeImpl
> 1) The getHeader method sometimes adds missing header elements and sometimes it does not. This violates the javadoc for the method and is the kind of random behavior that should be avoided. (In addition, when the current code adds a header it causes a full expansion of the om tree.)
> 2) The SOAPEnvelopeImpl.addChild method is improved to consider the parser state when adding the header. In the current code it is possible that this method will add the header twice, or add the header after the body.
> (!) I also discovered that searching for missing headers can also cause the full expansion of the om tree. The culprit in such cases was the misuse of the getElementByName method. But I see that these errors have already been fixed in the current version of the code. (Thank you to the kind soul who discovered this already !)
> I have run all of the axiom and axis2 tests with my new changes, which I will be adding shortly.
> These changes were found by the IBM Performance Analysist team. Special thanks to David Strite for detecting the om expansion problem!
> Thanks,
> Rich
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Commented: (WSCOMMONS-194) SOAPEnvelope getHeader processing
Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506134 ]
Glen Daniels commented on WSCOMMONS-194:
----------------------------------------
What dims said - if you've already got fixes for this, please submit a patch. Otherwise I'm happy to fix this stuff, just let us know. Thanks!
> SOAPEnvelope getHeader processing
> ---------------------------------
>
> Key: WSCOMMONS-194
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-194
> Project: WS-Commons
> Issue Type: Bug
> Reporter: Rich Scheuerle
>
> There are a few fundamental problems in the header processing in SOAPEnvelopeImpl
> 1) The getHeader method sometimes adds missing header elements and sometimes it does not. This violates the javadoc for the method and is the kind of random behavior that should be avoided. (In addition, when the current code adds a header it causes a full expansion of the om tree.)
> 2) The SOAPEnvelopeImpl.addChild method is improved to consider the parser state when adding the header. In the current code it is possible that this method will add the header twice, or add the header after the body.
> (!) I also discovered that searching for missing headers can also cause the full expansion of the om tree. The culprit in such cases was the misuse of the getElementByName method. But I see that these errors have already been fixed in the current version of the code. (Thank you to the kind soul who discovered this already !)
> I have run all of the axiom and axis2 tests with my new changes, which I will be adding shortly.
> These changes were found by the IBM Performance Analysist team. Special thanks to David Strite for detecting the om expansion problem!
> Thanks,
> Rich
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org
[jira] Commented: (WSCOMMONS-194) SOAPEnvelope getHeader processing
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506005 ]
Davanum Srinivas commented on WSCOMMONS-194:
--------------------------------------------
Rich,
Is this fixed already in svn? Is there a patch that we can apply?
thanks,
dims
> SOAPEnvelope getHeader processing
> ---------------------------------
>
> Key: WSCOMMONS-194
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-194
> Project: WS-Commons
> Issue Type: Bug
> Reporter: Rich Scheuerle
>
> There are a few fundamental problems in the header processing in SOAPEnvelopeImpl
> 1) The getHeader method sometimes adds missing header elements and sometimes it does not. This violates the javadoc for the method and is the kind of random behavior that should be avoided. (In addition, when the current code adds a header it causes a full expansion of the om tree.)
> 2) The SOAPEnvelopeImpl.addChild method is improved to consider the parser state when adding the header. In the current code it is possible that this method will add the header twice, or add the header after the body.
> (!) I also discovered that searching for missing headers can also cause the full expansion of the om tree. The culprit in such cases was the misuse of the getElementByName method. But I see that these errors have already been fixed in the current version of the code. (Thank you to the kind soul who discovered this already !)
> I have run all of the axiom and axis2 tests with my new changes, which I will be adding shortly.
> These changes were found by the IBM Performance Analysist team. Special thanks to David Strite for detecting the om expansion problem!
> Thanks,
> Rich
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org