You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/12 16:36:27 UTC
[GitHub] [spark] pgandhi999 commented on issue #24359: Revert
[SPARK-23433][SPARK-25250][CORE] Later created TaskSet should learn about
the finished partitions
pgandhi999 commented on issue #24359: Revert [SPARK-23433][SPARK-25250][CORE] Later created TaskSet should learn about the finished partitions
URL: https://github.com/apache/spark/pull/24359#issuecomment-482640917
The revert looks good to me, however, still do not understand why the job hangs. When a task finishes, we instantly mark the partition of that task in the corresponding TaskSet completed. The PR #23871 focused on updating the partition info in other TaskSets for the same stage.
> TaskSchedulerImpl thinks a stage's task set is completed when all tasks finish (see the code).
So technically, shouldn't this imply partition in the same TaskSet has already been marked as completed? Just thinking out loud.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org