You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by ajayyadava <gi...@git.apache.org> on 2016/08/20 11:32:07 UTC
[GitHub] incubator-carbondata pull request #80: CARBONDATA-164 Add template for pull ...
GitHub user ajayyadava opened a pull request:
https://github.com/apache/incubator-carbondata/pull/80
CARBONDATA-164 Add template for pull requests
Added a template for pull requests along the lines of Apache Beam
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajayyadava/incubator-carbondata 164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit 9e56822d9921d4e74c650d063678b67dae81cbea
Author: Ajay Yadava <aj...@apache.org>
Date: 2016-08-19T13:48:21Z
CARBONDATA-164 Add template for pull requests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #80: CARBONDATA-164 Add template for pull ...
Posted by umamaheswararao <gi...@git.apache.org>.
Github user umamaheswararao commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/80#discussion_r76740767
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,13 @@
+Be sure to do all of the following to help us incorporate your contribution
+quickly and easily:
+
+ - [ ] Make sure the PR title is formatted like:
+ `[CARBONDATA-<Jira issue #>] Description of pull request`
+ - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
+ Travis-CI on your fork and ensure the whole test matrix passes).
+ - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
+ number, if there is one.
+ - [ ] If this contribution is large, please file an Apache
+ [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
--- End diff --
Additionally, If contribution is large, how about suggesting to file umbrella JIRA and raise smaller sub JIRAs? Many projects follow this. Always make smaller patches to get reviews easy?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #80: CARBONDATA-164 Add template for pull ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #80: CARBONDATA-164 Add template for pull ...
Posted by ajayyadava <gi...@git.apache.org>.
Github user ajayyadava commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/80#discussion_r77155687
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,13 @@
+Be sure to do all of the following to help us incorporate your contribution
+quickly and easily:
+
+ - [ ] Make sure the PR title is formatted like:
+ `[CARBONDATA-<Jira issue #>] Description of pull request`
+ - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
+ Travis-CI on your fork and ensure the whole test matrix passes).
+ - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
+ number, if there is one.
+ - [ ] If this contribution is large, please file an Apache
+ [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
--- End diff --
Excellent suggestion. Will add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---