You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2025/01/07 17:03:25 UTC
(superset) branch master updated: chore(ff): deprecating `DRILL_TO_DETAIL` feature flag to launch it prime-time (#31412)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d68f8d11fe chore(ff): deprecating `DRILL_TO_DETAIL` feature flag to launch it prime-time (#31412)
d68f8d11fe is described below
commit d68f8d11fe39157fd6639a10d897f171333364e0
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Jan 7 10:03:17 2025 -0700
chore(ff): deprecating `DRILL_TO_DETAIL` feature flag to launch it prime-time (#31412)
---
RESOURCES/FEATURE_FLAGS.md | 2 +-
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts | 1 +
superset/config.py | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md
index f985ad7254..a09fb00b55 100644
--- a/RESOURCES/FEATURE_FLAGS.md
+++ b/RESOURCES/FEATURE_FLAGS.md
@@ -44,7 +44,6 @@ These features are **finished** but currently being tested. They are usable, but
- ALLOW_FULL_CSV_EXPORT
- CACHE_IMPERSONATION
- CONFIRM_DASHBOARD_DIFF
-- DRILL_TO_DETAIL
- DYNAMIC_PLUGINS
- ENABLE_SUPERSET_META_DB: [(docs)](https://superset.apache.org/docs/configuration/databases/#querying-across-databases)
- ESTIMATE_QUERY_COST
@@ -99,5 +98,6 @@ These features flags currently default to True and **will be removed in a future
- AVOID_COLORS_COLLISION
- DASHBOARD_CROSS_FILTERS
+- DRILL_TO_DETAIL
- ENABLE_JAVASCRIPT_CONTROLS
- KV_STORE
diff --git a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
index be28944a91..e20d94c7d8 100644
--- a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
+++ b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
@@ -36,6 +36,7 @@ export enum FeatureFlag {
DashboardRbac = 'DASHBOARD_RBAC',
DatapanelClosedByDefault = 'DATAPANEL_CLOSED_BY_DEFAULT',
DisableLegacyDatasourceEditor = 'DISABLE_LEGACY_DATASOURCE_EDITOR',
+ /** @deprecated */
DrillToDetail = 'DRILL_TO_DETAIL',
DrillBy = 'DRILL_BY',
DynamicPlugins = 'DYNAMIC_PLUGINS',
diff --git a/superset/config.py b/superset/config.py
index 8c31f6cfb7..3fc94cd27c 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -526,7 +526,7 @@ DEFAULT_FEATURE_FLAGS: dict[str, bool] = {
"CACHE_QUERY_BY_USER": False,
# Enable sharing charts with embedding
"EMBEDDABLE_CHARTS": True,
- "DRILL_TO_DETAIL": True,
+ "DRILL_TO_DETAIL": True, # deprecated
"DRILL_BY": True,
"DATAPANEL_CLOSED_BY_DEFAULT": False,
"HORIZONTAL_FILTER_BAR": False,