You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/06/03 10:26:00 UTC
[jira] [Commented] (HIVE-19267) Create/Replicate ACID Write event
[ https://issues.apache.org/jira/browse/HIVE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499359#comment-16499359 ]
Hive QA commented on HIVE-19267:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 28s{color} | {color:blue} common in master has 62 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} hcatalog/server-extensions in master has 4 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 34s{color} | {color:blue} ql in master has 2278 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 37s{color} | {color:blue} standalone-metastore in master has 214 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 16s{color} | {color:red} server-extensions in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 16s{color} | {color:red} hcatalog-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 28s{color} | {color:red} ql in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} The patch common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} hcatalog/server-extensions: The patch generated 0 new + 4 unchanged - 3 fixed = 4 total (was 7) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} The patch hcatalog-unit passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 20s{color} | {color:red} itests/hive-unit: The patch generated 34 new + 583 unchanged - 5 fixed = 617 total (was 588) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 46s{color} | {color:red} ql: The patch generated 8 new + 1301 unchanged - 32 fixed = 1309 total (was 1333) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 34s{color} | {color:red} standalone-metastore: The patch generated 9 new + 2163 unchanged - 6 fixed = 2172 total (was 2169) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 43 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 31s{color} | {color:red} hcatalog/server-extensions generated 1 new + 2 unchanged - 2 fixed = 3 total (was 4) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s{color} | {color:green} hive-unit in the patch passed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 42s{color} | {color:red} ql generated 1 new + 2277 unchanged - 1 fixed = 2278 total (was 2278) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 49s{color} | {color:green} standalone-metastore generated 0 new + 213 unchanged - 1 fixed = 213 total (was 214) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 0s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hcatalog/server-extensions |
| | org.apache.hive.hcatalog.listener.DbNotificationListener.addWriteNotificationLog(NotificationEvent, AcidWriteEvent, Connection, SQLGenerator, AcidWriteMessage) passes a nonconstant String to an execute or addBatch method on an SQL statement At DbNotificationListener.java:passes a nonconstant String to an execute or addBatch method on an SQL statement At DbNotificationListener.java:[line 779] |
| FindBugs | module:ql |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.parse.repl.dump.events.CommitTxnHandler.writer(EventHandler$Context, Path):in org.apache.hadoop.hive.ql.parse.repl.dump.events.CommitTxnHandler.writer(EventHandler$Context, Path): new java.io.OutputStreamWriter(OutputStream) At CommitTxnHandler.java:[line 52] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11469/dev-support/hive-personality.sh |
| git revision | master / 3bccc4e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/patch-mvninstall-hcatalog_server-extensions.txt |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/patch-mvninstall-itests_hcatalog-unit.txt |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/patch-mvninstall-ql.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/diff-checkstyle-itests_hive-unit.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/diff-checkstyle-ql.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/diff-checkstyle-standalone-metastore.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/whitespace-eol.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/new-findbugs-hcatalog_server-extensions.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus/new-findbugs-ql.html |
| modules | C: common hcatalog/server-extensions itests/hcatalog-unit itests/hive-unit ql standalone-metastore U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11469/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Create/Replicate ACID Write event
> ---------------------------------
>
> Key: HIVE-19267
> URL: https://issues.apache.org/jira/browse/HIVE-19267
> Project: Hive
> Issue Type: Sub-task
> Components: repl, Transactions
> Affects Versions: 3.0.0
> Reporter: mahesh kumar behera
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: ACID, DR, pull-request-available, replication
> Attachments: HIVE-19267.01.patch, HIVE-19267.02.patch, HIVE-19267.03.patch, HIVE-19267.04.patch, HIVE-19267.05.patch, HIVE-19267.06.patch, HIVE-19267.07.patch, HIVE-19267.08.patch, HIVE-19267.09.patch
>
>
>
> h1. Replicate ACID write Events
> * Create new EVENT_WRITE event with related message format to log the write operations with in a txn along with data associated.
> * Log this event when perform any writes (insert into, insert overwrite, load table, delete, update, merge, truncate) on table/partition.
> * If a single MERGE/UPDATE/INSERT/DELETE statement operates on multiple partitions, then need to log one event per partition.
> * DbNotificationListener should log this type of event to special metastore table named "MTxnWriteNotificationLog".
> * This table should maintain a map of txn ID against list of tables/partitions written by given txn.
> * The entry for a given txn should be removed by the cleaner thread that removes the expired events from EventNotificationTable.
> h1. Replicate Commit Txn operation (with writes)
> Add new EVENT_COMMIT_TXN to log the metadata/data of all tables/partitions modified within the txn.
> *Source warehouse:*
> * This event should read the EVENT_WRITEs from "MTxnWriteNotificationLog" metastore table to consolidate the list of tables/partitions modified within this txn scope.
> * Based on the list of tables/partitions modified and table Write ID, need to compute the list of delta files added by this txn.
> * Repl dump should read this message and dump the metadata and delta files list.
> *Target warehouse:*
> * Ensure snapshot isolation at target for on-going read txns which shouldn't view the data replicated from committed txn. (Ensured with open and allocate write ID events).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)