You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ms...@apache.org on 2025/09/18 21:47:52 UTC
(superset) branch master updated: chore(matrixify): Remove leftover option (#35195)
This is an automated email from the ASF dual-hosted git repository.
msyavuz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 38297edc6b chore(matrixify): Remove leftover option (#35195)
38297edc6b is described below
commit 38297edc6b7abe128ade4f8361156629aaed335f
Author: Mehmet Salih Yavuz <sa...@proton.me>
AuthorDate: Fri Sep 19 00:47:47 2025 +0300
chore(matrixify): Remove leftover option (#35195)
---
.../packages/superset-ui-core/src/chart/types/matrixify.test.ts | 3 ++-
.../packages/superset-ui-core/src/chart/types/matrixify.ts | 3 ---
superset-frontend/src/components/Chart/ChartRenderer.test.jsx | 1 -
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.test.ts b/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.test.ts
index cdc556b69f..3ac8fa4b0a 100644
--- a/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.test.ts
+++ b/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.test.ts
@@ -204,7 +204,8 @@ test('getMatrixifyConfig should handle topn selection mode', () => {
test('getMatrixifyValidationErrors should return empty array when matrixify is not enabled', () => {
const formData = {
viz_type: 'table',
- matrixify_enabled: false,
+ matrixify_enable_vertical_layout: false,
+ matrixify_enable_horizontal_layout: false,
} as MatrixifyFormData;
expect(getMatrixifyValidationErrors(formData)).toEqual([]);
diff --git a/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.ts b/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.ts
index 6573cf7afa..e90a6b3a87 100644
--- a/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.ts
+++ b/superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.ts
@@ -96,9 +96,6 @@ export interface MatrixifyAxisConfig {
* Complete Matrixify configuration in form data
*/
export interface MatrixifyFormData {
- // Enable/disable matrixify functionality
- matrixify_enabled?: boolean;
-
// Layout enable controls
matrixify_enable_vertical_layout?: boolean;
matrixify_enable_horizontal_layout?: boolean;
diff --git a/superset-frontend/src/components/Chart/ChartRenderer.test.jsx b/superset-frontend/src/components/Chart/ChartRenderer.test.jsx
index c6cda719a7..8ae9ac3b01 100644
--- a/superset-frontend/src/components/Chart/ChartRenderer.test.jsx
+++ b/superset-frontend/src/components/Chart/ChartRenderer.test.jsx
@@ -182,7 +182,6 @@ test('should handle matrixify-related form data changes', () => {
const initialProps = {
...requiredProps,
formData: {
- matrixify_enabled: false,
regular_control: 'value1',
},
queriesResponse: [{ data: 'current' }],