You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/04 23:28:10 UTC
[jira] [Commented] (BEAM-397) Format string uses \n rather than %n
[ https://issues.apache.org/jira/browse/BEAM-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361834#comment-15361834 ]
ASF GitHub Bot commented on BEAM-397:
-------------------------------------
GitHub user lucasallan opened a pull request:
https://github.com/apache/incubator-beam/pull/589
[BEAM-397] - Fixes Format string - it should use %n instead of \n
For more information: https://issues.apache.org/jira/browse/BEAM-397
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lucasallan/incubator-beam beam-397
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/589.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #589
----
commit d8943fd552071d95e7650770cbed77e2eee6eab8
Author: Lucas Amorim <lu...@protonmail.com>
Date: 2016-07-04T23:26:24Z
[BEAM-397] - Fixes Format string - it should use %n instead of \n
It fixes format string on Coder.NonDeterministicExeption.getMessage.
For more information: https://issues.apache.org/jira/browse/BEAM-397
----
> Format string uses \n rather than %n
> ------------------------------------
>
> Key: BEAM-397
> URL: https://issues.apache.org/jira/browse/BEAM-397
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs VA_FORMAT_STRING_USES_NEWLINE|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L72]: Format string should use %n rather than \n.
> Applies to: [Coder.NonDeterministicExeption.getMessage|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java#L296]
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)