You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/09/07 19:58:56 UTC

[Bug 58342] New: org.apache.tomcat.websocket.WsSession has repeated conditional tests

https://bz.apache.org/bugzilla/show_bug.cgi?id=58342

            Bug ID: 58342
           Summary: org.apache.tomcat.websocket.WsSession has repeated
                    conditional tests
           Product: Tomcat 9
           Version: unspecified
          Hardware: PC
            Status: NEW
          Severity: minor
          Priority: P2
         Component: WebSocket
          Assignee: dev@tomcat.apache.org
          Reporter: dinesh.a.joshi@gmail.com

Created attachment 33078
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33078&action=edit
Patch file

In the method WsSession.removeMessageHandler(), two `if` statements have
repeated conditional tests. I did not investigate whether older versions of
Tomcat have it however they're present in trunk. I am attaching a patch to fix
it. I ran the tests and they passed with my changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 58342] org.apache.tomcat.websocket.WsSession has repeated conditional tests

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58342

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 OS|                            |All
         Resolution|---                         |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Many thanks for the report and the patch.

Your patch has been applied to trunk, 8.0.x (for 8.0.27 onwards) and 7.0.x (for
7.0.65 onwards).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 58342] org.apache.tomcat.websocket.WsSession has repeated conditional tests

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58342

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33078|0                           |1
           is patch|                            |
  Attachment #33078|application/mbox            |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org