You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/17 06:47:11 UTC
[GitHub] [incubator-mxnet] samskalicky commented on issue #16131: Fix for
duplicate subgraph inputs/outputs
samskalicky commented on issue #16131: Fix for duplicate subgraph inputs/outputs
URL: https://github.com/apache/incubator-mxnet/pull/16131#issuecomment-532085171
@ZhennanQin ive made the changes, do they still look good? If so we can start going through and updating all other subgraph properties.
Regarding the update, what do you think we should do with properties that implement the standard logic for connectSubgraphInputs like:
https://github.com/apache/incubator-mxnet/blob/35e6d7a0edac416532bb754ba4e570a9df67463e/src/operator/subgraph/mkldnn/mkldnn_conv_property.h#L236-L243
Should we just eliminate this definition and continue to use the parent/standard implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services