[jira] [Commented] (CLOUDSTACK-9011) user_vm_view does not check for account_id of keypairs

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982434#comment-14982434 ] 

ASF subversion and git services commented on CLOUDSTACK-9011:
-------------------------------------------------------------

Commit bc5a5d662340030fe8f3182f4b3385682a890c47 in cloudstack's branch refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bc5a5d6 ]

Merge pull request #1006 from greenqloud/user_vm_keypairs_fix

Fixed user_vm_view to only display keypairs belonging to the account.The user_vm_view displayes the keypair information by joining vm_details with ssh_keypairs on the key value exclusively.

We found a scenario in which this can cause information leakage. If there are two accounts using the same key, but create a different key name for it, and then a vm is created using one of the keys, the view will list both keypairs as belonging to the vm, which can in turn cause confusion to the users who see a keypair name which they did not create.

The fix simply limits the view to displaying keypairs which belong to vm's account.

I added it to the latest schema migration only; should I also include it in the previous ones?

* pr/1006:
  CLOUDSTACK-9011 - Fixed user_vm_view to only display keypairs belonging to the account.

Signed-off-by: Remi Bergsma <gi...@remi.nl>


> user_vm_view does not check for account_id of keypairs 
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-9011
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9011
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Nera NEsic
>            Priority: Minor
>
> If there are two accounts using the same key, but create a different key name for it, and then a vm is created using one of the keys, the view will list both keypairs as belonging to the vm, which can in turn cause confusion to the users who see a keypair name which they did not create.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)