Re: [PR] [Fix-16680][ApiServer] Query project list paging error [dolphinscheduler]

["shouwangyw (via GitHub)" <gi...@apache.org>]

shouwangyw commented on code in PR #16681:
URL: https://github.com/apache/dolphinscheduler/pull/16681#discussion_r1794919800


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionMapper.xml:
##########
@@ -200,10 +200,14 @@
             project_code as projectCode
             ,count(*) as count
         from t_ds_workflow_definition
-        where project_code in
-        <foreach collection="projectCodes" index="index" item="i" open="(" separator="," close=")">
-            #{i}
-        </foreach>
+        <where>

Review Comment:
   > We should not do this query while projectCodes is null
   
   Is it not possible to query all project when projectCodes is null？？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org