You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/23 17:42:46 UTC
[GitHub] [spark] holdenk opened a new pull request #29854: [WIP][SPARK-32979][K8S] Fix decom tests and add some comments to reduce chance of breakage
holdenk opened a new pull request #29854:
URL: https://github.com/apache/spark/pull/29854
### What changes were proposed in this pull request?
Fixes the log strings the decom integration tests looks for and add comments reminding people to run the K8s integration tests when changing those code paths.
### Why are the changes needed?
The strings it looks for have been changed.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
WIP: Verify that the K8s jenkins job succeeds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698007198
Yes! Finally, it passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697990499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697985907
**[Test build #129048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129048/testReport)** for PR 29854 at commit [`d5b1095`](https://github.com/apache/spark/commit/d5b1095ac8f0b44a34d2deeaa2602feeefebf10a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697880287
Jenkins retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698038747
Thanks @holdenk and @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697936948
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33664/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697957673
**[Test build #129040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)** for PR 29854 at commit [`64d6dd8`](https://github.com/apache/spark/commit/64d6dd8be689d59785f2205a6586f665dc8057c7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698026315
**[Test build #129043 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129043/testReport)** for PR 29854 at commit [`d5b1095`](https://github.com/apache/spark/commit/d5b1095ac8f0b44a34d2deeaa2602feeefebf10a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697841472
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33662/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698693708
So the launcher tests were broken by a new version of mini kube being released, it wasn’t broken by any specific PR (except maybe arguably the original PR adding integration tests).
As for the revert, that PR was indeed breaking the test suite and had an incompatible change, I asked for it to be reverted but it turned out that folks have not been running that suite for awhile (a mistake I myself have made), so it there were multiple breaking changes and I decided that since it had been proposed to re-merge code with a broken test suite we would be better served by me focusing on fixing the test suite to unblock everyone.
If you think this is not a reasonable course of action please bring it up with the PMC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697936962
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697985907
**[Test build #129048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129048/testReport)** for PR 29854 at commit [`d5b1095`](https://github.com/apache/spark/commit/d5b1095ac8f0b44a34d2deeaa2602feeefebf10a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698006632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698027137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697989432
**[Test build #129042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129042/testReport)** for PR 29854 at commit [`64d6dd8`](https://github.com/apache/spark/commit/64d6dd8be689d59785f2205a6586f665dc8057c7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698006612
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33669/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697782860
**[Test build #129040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)** for PR 29854 at commit [`64d6dd8`](https://github.com/apache/spark/commit/64d6dd8be689d59785f2205a6586f665dc8057c7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983134
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33665/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697938741
So The test failure is for `- Launcher client dependencies *** FAILED ***` but the decommissioning test is passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698689697
@holdenk, BTW which PR caused this failure? It's a bit odd that we fix a test as a followup here whereas you ask to revert at https://github.com/apache/spark/pull/29722#issuecomment-695517007 https://github.com/apache/spark/pull/29722#issuecomment-695517162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697936962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697883527
**[Test build #129042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129042/testReport)** for PR 29854 at commit [`64d6dd8`](https://github.com/apache/spark/commit/64d6dd8be689d59785f2205a6586f665dc8057c7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698689697
@holdenk, BTW which PR caused this failure? It's a bit odd that we fix a test as a followup here whereas you ask to revert at https://github.com/apache/spark/pull/29722#issuecomment-695517007 https://github.com/apache/spark/pull/29722#issuecomment-695517162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697953562
**[Test build #129043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129043/testReport)** for PR 29854 at commit [`d5b1095`](https://github.com/apache/spark/commit/d5b1095ac8f0b44a34d2deeaa2602feeefebf10a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983109
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33665/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698037657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697983126
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32979][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697782860
**[Test build #129040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)** for PR 29854 at commit [`64d6dd8`](https://github.com/apache/spark/commit/64d6dd8be689d59785f2205a6586f665dc8057c7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698037064
**[Test build #129048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129048/testReport)** for PR 29854 at commit [`d5b1095`](https://github.com/apache/spark/commit/d5b1095ac8f0b44a34d2deeaa2602feeefebf10a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697869081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697869016
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33662/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697883527
**[Test build #129042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129042/testReport)** for PR 29854 at commit [`64d6dd8`](https://github.com/apache/spark/commit/64d6dd8be689d59785f2205a6586f665dc8057c7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697958769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29854:
URL: https://github.com/apache/spark/pull/29854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698693708
So the launcher tests were broken by a new version of mini kube being released, it wasn’t broken by any specific PR (except maybe arguably the original PR adding integration tests).
As for the revert, that PR was indeed breaking the test suite and had an incompatible change, I asked for it to be reverted but it turned out that folks have not been running that suite for awhile (a mistake I myself have made), so it there were multiple breaking changes and I decided that since it had been proposed to re-merge code with a broken test suite we would be better served by me focusing on fixing the test suite to unblock everyone.
If you think this is not a reasonable course of action please bring it up with the PMC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697998683
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33669/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697990499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697982974
jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698006632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697958769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698027137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697989257
Thank you, @holdenk ! Let's see K8s IT result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697973000
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33665/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697929022
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33664/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698037657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697936967
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33664/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697982902
cc @Ngone51 @HyukjinKwon @ScrapCodes @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29854: [SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-698008172
Merged to master because it recovers K8s IT and unblocks K8s module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697869081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29854:
URL: https://github.com/apache/spark/pull/29854#issuecomment-697953562
**[Test build #129043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129043/testReport)** for PR 29854 at commit [`d5b1095`](https://github.com/apache/spark/commit/d5b1095ac8f0b44a34d2deeaa2602feeefebf10a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org