[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10562: fix(thumbnails): missing field, logging and new config var

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10562:
URL: https://github.com/apache/incubator-superset/pull/10562#discussion_r468025755



##########
File path: superset/config.py
##########
@@ -797,6 +797,8 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 
 # Any config options to be passed as-is to the webdriver
 WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+# The webdriver to use supports "chrome" and "firefox"
+WEBDRIVER_TYPE = "firefox"

Review comment:
       let's use EMAIL_REPORTS_WEBDRIVER or just converge those 2
   easy solution would be:
   ```
   EMAIL_REPORTS_WEBDRIVER = EMAIL_REPORTS_WEBDRIVER
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org