[jira] [Commented] (WICKET-4833) DateConverter is not thread-safe

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483114#comment-13483114 ] 

Martin Grigorov commented on WICKET-4833:
-----------------------------------------

Looking at java.text.DateFormat#get() it may return a pooled one...
                
> DateConverter is not thread-safe
> --------------------------------
>
>                 Key: WICKET-4833
>                 URL: https://issues.apache.org/jira/browse/WICKET-4833
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.19, 6.2.0
>            Reporter: SoulSpirit
>
> As described in https://issues.apache.org/jira/browse/WICKET-102 , DateConverter internally uses DateFormat to do its job, without the external synchronization DateFormat's javadoc states it need.
> Since DateConverter is used by Wicket in a multi-threaded scenario (converters instances can be shared between threads) it should guarantee thread-safeness.
> A user of DateConverter (and he could be unaware of using a DateConverter) shouldn't worry about its internal mechanics, thus DateConverter should handle the synchronization by itself.
> Tested on v1.4.19, and just browsed v6.2.0 sources to check if something changed.
> Thanks in advance, and sorry for my sloppy english.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira