You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/09 08:55:46 UTC
[GitHub] [bookkeeper] mattisonchao opened a new pull request #3030: Fix performance issues to avoid unnecessary loops.
mattisonchao opened a new pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030
### Motivation
When we get the right ``authorized`` state, we need to return immediately, do not need to do an unnecessary loop.
### Changes
- Add ``break``, when get the right ``authorized`` state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mattisonchao commented on pull request #3030: Fix performance issues to avoid unnecessary loops.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030#issuecomment-1033682549
Could I use some commands to rerun failed test?
I think it's a flaky test, my change can not affect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3030: Fix performance issues to avoid unnecessary loops.
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mattisonchao commented on pull request #3030: Fix performance issues to avoid unnecessary loops.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030#issuecomment-1033701880
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mattisonchao removed a comment on pull request #3030: Fix performance issues to avoid unnecessary loops.
Posted by GitBox <gi...@apache.org>.
mattisonchao removed a comment on pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030#issuecomment-1033609061
Oh, thanks for the explanation. @eolivelli
But I think I can start small to get involved in community contributions. What would you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mattisonchao commented on pull request #3030: Fix performance issues to avoid unnecessary loops.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030#issuecomment-1033609061
Oh, thanks for the explanation. @eolivelli
But I think I can start small to get involved in community contributions. What would you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mattisonchao commented on pull request #3030: Fix performance issues to avoid unnecessary loops.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #3030:
URL: https://github.com/apache/bookkeeper/pull/3030#issuecomment-1033513208
@merlimat @eolivelli @dlg99 @nicoloboschi PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org