You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/10 21:55:45 UTC
[GitHub] [camel-quarkus] dufoli opened a new pull request #3008: fix extension creation on Windows
dufoli opened a new pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008
fix #2999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] dufoli commented on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
dufoli commented on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896556905
I have create a new PR for full windows support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] dufoli commented on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
dufoli commented on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896555982
@ppalaga done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] dufoli commented on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
dufoli commented on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896553129
I am still failing on JfrConfigInterceptorTest with tempdir injection with NPE. I do not know if it is a junit test or an environment issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga edited a comment on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896554133
Thanks @dufoli , 6524d57 looks good.
I'd like to see the other Windows fixes pass the CI separately. Could you please submit them as a separate PR (and remove them from here)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896693629
Yep, looks good, thanks @dufoli!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896640382
Are we ok with closing this as the work is occurring in [another PR](https://github.com/apache/camel-quarkus/pull/3009) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3008: fix extension creation on Windows
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3008:
URL: https://github.com/apache/camel-quarkus/pull/3008#issuecomment-896554133
Thanks @dufoli , 6524d57 looks good.
I'd like to see the other Windows fixes pass the CI separately. Could you please submit them as a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org