You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/15 01:22:03 UTC

[GitHub] [ozone] errose28 opened a new pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

errose28 opened a new pull request #2638:
URL: https://github.com/apache/ozone/pull/2638


   ## What changes were proposed in this pull request?
   
   - Add filters to Recon APIs to authenticate users when security is enabled.
   - Add the ability to restrict endpoints to access only by configured `ozone.administrators` or the new `ozone.recon.administrators`.
       - See the descriptions added to the config for details.
   
   ## What is the link to the Apache JIRA
   
   HDDS-5691
   
   ## How was this patch tested?
   
   - Acceptance tests added
   - Unit tests added
       - Includes a test requiring new endpoints to either be marked as `@AdminOnly` or explicitly granted an exception by modifying the test.
   - Manual testing with docker


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] swagle commented on a change in pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
swagle commented on a change in pull request #2638:
URL: https://github.com/apache/ozone/pull/2638#discussion_r711390323



##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconRestServletModule.java
##########
@@ -32,73 +34,111 @@
 import org.glassfish.jersey.servlet.ServletContainer;
 import org.jvnet.hk2.guice.bridge.api.GuiceBridge;
 import org.jvnet.hk2.guice.bridge.api.GuiceIntoHK2Bridge;
+import org.reflections.Reflections;
+import org.reflections.scanners.SubTypesScanner;
+import org.reflections.scanners.TypeAnnotationsScanner;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.google.inject.Injector;
-import com.google.inject.Scopes;
-import com.google.inject.servlet.ServletModule;
+import javax.ws.rs.Path;
+import java.net.URL;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
+import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ACL_ENABLED;
+import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ACL_ENABLED_DEFAULT;
 
 /**
  * Class to scan API Service classes and bind them to the injector.
  */
-public abstract class ReconRestServletModule extends ServletModule {
+public class ReconRestServletModule extends ServletModule {
+
+  public static final String BASE_API_PATH = "/api/v1";
+  public static final String API_PACKAGE = "org.apache.hadoop.ozone.recon.api";
 
   private static final Logger LOG =
       LoggerFactory.getLogger(ReconRestServletModule.class);
 
-  @Override
-  protected abstract void configureServlets();
+  private final ConfigurationSource conf;
 
-  /**
-   * Interface to provide packages for scanning.
-   */
-  public interface RestKeyBindingBuilder {
-    void packages(String... packages);
+  public ReconRestServletModule(ConfigurationSource conf) {
+    this.conf = conf;
   }
 
-  protected RestKeyBindingBuilder rest(String... urlPatterns) {
-    return new RestKeyBindingBuilderImpl(Arrays.asList(urlPatterns));
+  @Override
+  protected void configureServlets() {
+    configureApi(BASE_API_PATH, API_PACKAGE);
   }
 
-  private class RestKeyBindingBuilderImpl implements RestKeyBindingBuilder {
-    private List<String> paths;
-
-    RestKeyBindingBuilderImpl(List<String> paths) {
-      this.paths = paths;
-    }
+  private void configureApi(String baseApiPath, String... packages) {
+    StringBuilder sb = new StringBuilder();
+    Set<String> adminEndpoints = new HashSet<>();
 
-    private void checkIfPackageExistsAndLog(String pkg) {
-      String resourcePath = pkg.replace(".", "/");
-      URL resource = getClass().getClassLoader().getResource(resourcePath);
-      if (resource != null) {
-        LOG.info("rest({}).packages({})", paths, pkg);
-      } else {
-        LOG.info("No Beans in '{}' found. Requests {} will fail.", pkg, paths);
+    for (String pkg : packages) {
+      if (sb.length() > 0) {
+        sb.append(',');
+      }
+      checkIfPackageExistsAndLog(pkg, baseApiPath);
+      sb.append(pkg);
+      // Check for classes marked as admin only that will need an extra
+      // filter applied to their path.
+      Reflections reflections = new Reflections(pkg,
+          new TypeAnnotationsScanner(), new SubTypesScanner());
+      Set<Class<?>> adminEndpointClasses =
+          reflections.getTypesAnnotatedWith(AdminOnly.class);
+      adminEndpointClasses.stream()
+          .map(clss -> clss.getAnnotation(Path.class).value())
+          .forEachOrdered(adminEndpoints::add);
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Registered the following endpoint classes as admin only: {}",
+            adminEndpointClasses);
       }
     }
+    Map<String, String> params = new HashMap<>();
+    params.put("javax.ws.rs.Application",
+        GuiceResourceConfig.class.getCanonicalName());
+    if (sb.length() > 0) {
+      params.put("jersey.config.server.provider.packages", sb.toString());
+    }
+    bind(ServletContainer.class).in(Scopes.SINGLETON);
 
-    @Override
-    public void packages(String... packages) {
-      StringBuilder sb = new StringBuilder();
+    serve(baseApiPath + "/*").with(ServletContainer.class, params);
+    addFilters(baseApiPath, adminEndpoints);
+  }
 
-      for (String pkg : packages) {
-        if (sb.length() > 0) {
-          sb.append(',');
-        }
-        checkIfPackageExistsAndLog(pkg);
-        sb.append(pkg);
+  private void addFilters(String basePath, Set<String> subPaths) {
+    if (OzoneSecurityUtil.isHttpSecurityEnabled(conf)) {
+      filter(basePath + "/*").through(ReconAuthFilter.class);
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Added authentication filter to all paths under {}",
+            basePath);
       }
-      Map<String, String> params = new HashMap<>();
-      params.put("javax.ws.rs.Application",
-          GuiceResourceConfig.class.getCanonicalName());
-      if (sb.length() > 0) {
-        params.put("jersey.config.server.provider.packages", sb.toString());
+
+      boolean aclEnabled = conf.getBoolean(OZONE_ACL_ENABLED,
+          OZONE_ACL_ENABLED_DEFAULT);
+      if (aclEnabled) {
+        for (String path: subPaths) {
+          filter(basePath + path).through(ReconAdminFilter.class);

Review comment:
       Ideally, instead of string concat it is safer to use UrlBuilder which will take care of appending separators.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] swagle merged pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
swagle merged pull request #2638:
URL: https://github.com/apache/ozone/pull/2638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] errose28 commented on a change in pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
errose28 commented on a change in pull request #2638:
URL: https://github.com/apache/ozone/pull/2638#discussion_r712524378



##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/filters/ReconAdminFilter.java
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.recon.api.filters;
+
+import com.google.inject.Inject;
+import com.google.inject.Singleton;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.recon.ReconConfigKeys;
+import org.apache.hadoop.ozone.OzoneConfigKeys;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.servlet.Filter;
+import javax.servlet.FilterChain;
+import javax.servlet.FilterConfig;
+import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.IOException;
+import java.security.Principal;
+import java.util.Collection;
+
+import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ADMINISTRATORS_WILDCARD;
+
+/**
+ * Filter that can be applied to paths to only allow access by configured
+ * admins.
+ */
+@Singleton
+public class ReconAdminFilter implements Filter {
+
+  private static final Logger LOG =
+      LoggerFactory.getLogger(ReconAdminFilter.class);
+
+  private final OzoneConfiguration conf;
+
+  @Inject
+  ReconAdminFilter(OzoneConfiguration conf) {
+    this.conf = conf;
+  }
+
+  @Override
+  public void init(FilterConfig filterConfig) throws ServletException { }
+
+  @Override
+  public void doFilter(ServletRequest servletRequest,
+      ServletResponse servletResponse, FilterChain filterChain)
+      throws IOException, ServletException {
+
+    HttpServletRequest httpServletRequest =
+        (HttpServletRequest) servletRequest;
+    HttpServletResponse httpServletResponse =
+        (HttpServletResponse) servletResponse;
+
+    final Principal userPrincipal =
+        httpServletRequest.getUserPrincipal();
+    boolean isAdmin = false;
+    String userName = null;
+
+    if (userPrincipal != null) {
+      UserGroupInformation ugi =
+          UserGroupInformation.createRemoteUser(userPrincipal.getName());
+      userName = ugi.getUserName();
+
+      if (hasPermission(ugi)) {
+        isAdmin = true;
+        filterChain.doFilter(httpServletRequest, httpServletResponse);
+      }
+    }
+
+    if (isAdmin) {
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Allowing request from admin user {} to {}",
+            userName, httpServletRequest.getRequestURL());
+      }
+    } else {
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Rejecting request from non admin user {} to {}",

Review comment:
       Changed log level to warn for this message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] swagle commented on a change in pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
swagle commented on a change in pull request #2638:
URL: https://github.com/apache/ozone/pull/2638#discussion_r711391417



##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/filters/ReconAdminFilter.java
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.recon.api.filters;
+
+import com.google.inject.Inject;
+import com.google.inject.Singleton;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.recon.ReconConfigKeys;
+import org.apache.hadoop.ozone.OzoneConfigKeys;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.servlet.Filter;
+import javax.servlet.FilterChain;
+import javax.servlet.FilterConfig;
+import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.IOException;
+import java.security.Principal;
+import java.util.Collection;
+
+import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ADMINISTRATORS_WILDCARD;
+
+/**
+ * Filter that can be applied to paths to only allow access by configured
+ * admins.
+ */
+@Singleton
+public class ReconAdminFilter implements Filter {
+
+  private static final Logger LOG =
+      LoggerFactory.getLogger(ReconAdminFilter.class);
+
+  private final OzoneConfiguration conf;
+
+  @Inject
+  ReconAdminFilter(OzoneConfiguration conf) {
+    this.conf = conf;
+  }
+
+  @Override
+  public void init(FilterConfig filterConfig) throws ServletException { }
+
+  @Override
+  public void doFilter(ServletRequest servletRequest,
+      ServletResponse servletResponse, FilterChain filterChain)
+      throws IOException, ServletException {
+
+    HttpServletRequest httpServletRequest =
+        (HttpServletRequest) servletRequest;
+    HttpServletResponse httpServletResponse =
+        (HttpServletResponse) servletResponse;
+
+    final Principal userPrincipal =
+        httpServletRequest.getUserPrincipal();
+    boolean isAdmin = false;
+    String userName = null;
+
+    if (userPrincipal != null) {
+      UserGroupInformation ugi =
+          UserGroupInformation.createRemoteUser(userPrincipal.getName());
+      userName = ugi.getUserName();
+
+      if (hasPermission(ugi)) {
+        isAdmin = true;
+        filterChain.doFilter(httpServletRequest, httpServletResponse);
+      }
+    }
+
+    if (isAdmin) {
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Allowing request from admin user {} to {}",
+            userName, httpServletRequest.getRequestURL());
+      }
+    } else {
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Rejecting request from non admin user {} to {}",

Review comment:
       This is an audit event, we don't have recon audit log but the log level should be info/warn IMO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] errose28 commented on pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #2638:
URL: https://github.com/apache/ozone/pull/2638#issuecomment-923324822


   Thanks for reviews @swagle and @avijayanhwx. Comments should be addressed in the latest changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] errose28 commented on a change in pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
errose28 commented on a change in pull request #2638:
URL: https://github.com/apache/ozone/pull/2638#discussion_r712523449



##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconRestServletModule.java
##########
@@ -32,73 +34,111 @@
 import org.glassfish.jersey.servlet.ServletContainer;
 import org.jvnet.hk2.guice.bridge.api.GuiceBridge;
 import org.jvnet.hk2.guice.bridge.api.GuiceIntoHK2Bridge;
+import org.reflections.Reflections;
+import org.reflections.scanners.SubTypesScanner;
+import org.reflections.scanners.TypeAnnotationsScanner;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.google.inject.Injector;
-import com.google.inject.Scopes;
-import com.google.inject.servlet.ServletModule;
+import javax.ws.rs.Path;
+import java.net.URL;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
+import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ACL_ENABLED;
+import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ACL_ENABLED_DEFAULT;
 
 /**
  * Class to scan API Service classes and bind them to the injector.
  */
-public abstract class ReconRestServletModule extends ServletModule {
+public class ReconRestServletModule extends ServletModule {
+
+  public static final String BASE_API_PATH = "/api/v1";
+  public static final String API_PACKAGE = "org.apache.hadoop.ozone.recon.api";
 
   private static final Logger LOG =
       LoggerFactory.getLogger(ReconRestServletModule.class);
 
-  @Override
-  protected abstract void configureServlets();
+  private final ConfigurationSource conf;
 
-  /**
-   * Interface to provide packages for scanning.
-   */
-  public interface RestKeyBindingBuilder {
-    void packages(String... packages);
+  public ReconRestServletModule(ConfigurationSource conf) {
+    this.conf = conf;
   }
 
-  protected RestKeyBindingBuilder rest(String... urlPatterns) {
-    return new RestKeyBindingBuilderImpl(Arrays.asList(urlPatterns));
+  @Override
+  protected void configureServlets() {
+    configureApi(BASE_API_PATH, API_PACKAGE);
   }
 
-  private class RestKeyBindingBuilderImpl implements RestKeyBindingBuilder {
-    private List<String> paths;
-
-    RestKeyBindingBuilderImpl(List<String> paths) {
-      this.paths = paths;
-    }
+  private void configureApi(String baseApiPath, String... packages) {
+    StringBuilder sb = new StringBuilder();
+    Set<String> adminEndpoints = new HashSet<>();
 
-    private void checkIfPackageExistsAndLog(String pkg) {
-      String resourcePath = pkg.replace(".", "/");
-      URL resource = getClass().getClassLoader().getResource(resourcePath);
-      if (resource != null) {
-        LOG.info("rest({}).packages({})", paths, pkg);
-      } else {
-        LOG.info("No Beans in '{}' found. Requests {} will fail.", pkg, paths);
+    for (String pkg : packages) {
+      if (sb.length() > 0) {
+        sb.append(',');
+      }
+      checkIfPackageExistsAndLog(pkg, baseApiPath);
+      sb.append(pkg);
+      // Check for classes marked as admin only that will need an extra
+      // filter applied to their path.
+      Reflections reflections = new Reflections(pkg,
+          new TypeAnnotationsScanner(), new SubTypesScanner());
+      Set<Class<?>> adminEndpointClasses =
+          reflections.getTypesAnnotatedWith(AdminOnly.class);
+      adminEndpointClasses.stream()
+          .map(clss -> clss.getAnnotation(Path.class).value())
+          .forEachOrdered(adminEndpoints::add);
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Registered the following endpoint classes as admin only: {}",
+            adminEndpointClasses);
       }
     }
+    Map<String, String> params = new HashMap<>();
+    params.put("javax.ws.rs.Application",
+        GuiceResourceConfig.class.getCanonicalName());
+    if (sb.length() > 0) {
+      params.put("jersey.config.server.provider.packages", sb.toString());
+    }
+    bind(ServletContainer.class).in(Scopes.SINGLETON);
 
-    @Override
-    public void packages(String... packages) {
-      StringBuilder sb = new StringBuilder();
+    serve(baseApiPath + "/*").with(ServletContainer.class, params);
+    addFilters(baseApiPath, adminEndpoints);
+  }
 
-      for (String pkg : packages) {
-        if (sb.length() > 0) {
-          sb.append(',');
-        }
-        checkIfPackageExistsAndLog(pkg);
-        sb.append(pkg);
+  private void addFilters(String basePath, Set<String> subPaths) {
+    if (OzoneSecurityUtil.isHttpSecurityEnabled(conf)) {
+      filter(basePath + "/*").through(ReconAuthFilter.class);
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Added authentication filter to all paths under {}",
+            basePath);
       }
-      Map<String, String> params = new HashMap<>();
-      params.put("javax.ws.rs.Application",
-          GuiceResourceConfig.class.getCanonicalName());
-      if (sb.length() > 0) {
-        params.put("jersey.config.server.provider.packages", sb.toString());
+
+      boolean aclEnabled = conf.getBoolean(OZONE_ACL_ENABLED,
+          OZONE_ACL_ENABLED_DEFAULT);
+      if (aclEnabled) {
+        for (String path: subPaths) {
+          filter(basePath + path).through(ReconAdminFilter.class);

Review comment:
       I figured a utility existed somewhere for this I just couldn't find it. Switched to using UriBuilder to build the paths.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] swagle commented on pull request #2638: HDDS-5691. Restrict Recon NSSummaryEndpoint and ContainerEndpoint to admins.

Posted by GitBox <gi...@apache.org>.
swagle commented on pull request #2638:
URL: https://github.com/apache/ozone/pull/2638#issuecomment-922124171


   Thanks, @errose28 for working on this patch, changes look good. Minor comments above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org