You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/02/11 16:22:01 UTC

[2/3] lucene-solr git commit: LUCENE-6938: add TODO that we should also detect unpushed commits

LUCENE-6938: add TODO that we should also detect unpushed commits


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/9a4ff707
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/9a4ff707
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/9a4ff707

Branch: refs/heads/branch_5_5
Commit: 9a4ff707ed8d4aafa20dd3cc9c0fd4c7378046f2
Parents: e3a06f0
Author: Mike McCandless <mi...@apache.org>
Authored: Thu Feb 11 10:07:05 2016 -0500
Committer: Mike McCandless <mi...@apache.org>
Committed: Thu Feb 11 10:07:05 2016 -0500

----------------------------------------------------------------------
 dev-tools/scripts/buildAndPushRelease.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/9a4ff707/dev-tools/scripts/buildAndPushRelease.py
----------------------------------------------------------------------
diff --git a/dev-tools/scripts/buildAndPushRelease.py b/dev-tools/scripts/buildAndPushRelease.py
index c735621..6774e42 100644
--- a/dev-tools/scripts/buildAndPushRelease.py
+++ b/dev-tools/scripts/buildAndPushRelease.py
@@ -61,8 +61,10 @@ def getGitRev():
   status = os.popen('git status').read().strip()
   if 'nothing to commit, working directory clean' not in status:
     raise RuntimeError('git clone is dirty:\n\n%s' % status)
+
+  # TODO: we should also detect unpushed changes here?  Something like "git cherry -v origin/branch_5_5"?
+  print('  git clone is clean')
   return os.popen('git rev-parse HEAD').read().strip()
-  
 
 def prepare(root, version, gpgKeyID, gpgPassword):
   print()