[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #148: [Log Improvement] Output the registering/lost/exclude nodes in log

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #148:
URL: https://github.com/apache/incubator-uniffle/pull/148#discussion_r941263068


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -99,6 +101,13 @@ void nodesCheck() {
           }
         }
       }
+      if (!deleteIds.isEmpty() || outputAliveServerCount % 30 == 0) {
+        LOG.info("Alive servers number: {}, ids: {}",

Review Comment:
   Why do we need this? We have metrics tell us how many there are alive servers.



##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -118,12 +128,16 @@ private void updateExcludeNodes(String path) {
       } else {
         excludeNodes = Sets.newConcurrentHashSet();
       }
-      CoordinatorMetrics.gaugeExcludeServerNum.set(excludeNodes.size());
     } catch (FileNotFoundException fileNotFoundException) {
       excludeNodes = Sets.newConcurrentHashSet();
     } catch (Exception e) {
       LOG.warn("Error when updating exclude nodes, the exclude nodes file path: " + path, e);
     }
+    int newlyExcludeNodesNumber = excludeNodes.size();
+    if (newlyExcludeNodesNumber != originalExcludeNodesNumber) {

Review Comment:
   ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org