You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/12/12 04:20:35 UTC
[Bug 5748] New: sa-compile failure on latest on OSX/Leopard
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
Summary: sa-compile failure on latest on OSX/Leopard
Product: Spamassassin
Version: 3.2.3
Platform: Macintosh
OS/Version: Mac OS X
Status: NEW
Severity: major
Priority: P5
Component: sa-compile
AssignedTo: dev@spamassassin.apache.org
ReportedBy: schneecrash+apache@gmail.com
bldg a new svn co of sa 32x-branch (r602790) on osx 10.5.1/Leopard
builds fine,
spamassassin --version
SpamAssassin version 3.2.4-r585950
running on Perl version 5.8.8
an as-usual,
sa-compile --sudo -D
fires off a *lot* of previously unseen errors (below), but eventually
finishes with a
COMPILE DONE
no problems on OSX 10.4.11/Tiger.
hth!
...
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/av.h:13:
error: expected specifier-qualifier-list before 'SSize_t'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:17:
error: expected specifier-qualifier-list before 'BASEOP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:106:
error: expected specifier-qualifier-list before 'CV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:205:
error: expected specifier-qualifier-list before 'I32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:235:
error: expected specifier-qualifier-list before 'I32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:298:
error: expected specifier-qualifier-list before 'I32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:360:
error: expected specifier-qualifier-list before 'I32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:412:
error: expected specifier-qualifier-list before 'U32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:518:
error: expected specifier-qualifier-list before 'AV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cv.h:16:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/fakethr.h:28:
error: expected specifier-qualifier-list before 'IV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/gv.h:12:
error: expected specifier-qualifier-list before 'SV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:147:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'I8'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:148:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'U8'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:149:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'I16'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:150:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'U16'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:151:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'I32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:152:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'U32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/handy.h:536:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'line_t'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/hv.h:19:
error: expected specifier-qualifier-list before 'SV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/hv.h:24:
error: expected specifier-qualifier-list before 'U32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/hv.h:36:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/intrpvar.h:20:
error: expected ')' before 'int'
In file included from
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/iperlsys.h:51:
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:220:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'PERL_EXPORT_C'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:233:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'FILE'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:287:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:345:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:348:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:351:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'FILE'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:360:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:364:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:371:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:373:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/iperlsys.h:54:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'typedef'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/mg.h:15:
error: expected declaration specifiers or '...' before '*' token
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/mg.h:15:
error: expected ')' before 'SV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/mg.h:16:
error: expected ';' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/mg.h:27:
error: expected specifier-qualifier-list before 'MAGIC'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:228:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:232:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:237:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:243:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:249:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:255:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:334:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:339:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:344:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/op.h:349:
error: expected specifier-qualifier-list before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:31:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'EXT'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:390:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:751:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'START_EXTERN_C'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:1112:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:1471:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'U32'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:1829:
error: expected '=', ',', ';', 'asm' or '__attribute__' at end of
input
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/patchlevel.h:123:
error: 'NULL' undeclared here (not in a function)
In file included from
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:2761:
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/utf8.h:41:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'unsigned'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3440:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3442:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3444:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3446:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3448:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3450:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3452:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3454:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3456:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3458:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3460:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3462:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3464:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3466:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3468:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3470:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3472:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3474:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3476:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3479:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3487:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'const'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3488:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3566:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'unsigned'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3605:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'unsigned'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3681:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'unsigned'
In file included from
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3953:
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:31:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:390:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:754:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:1112:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OP'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/opcode.h:1471:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'U32'
In file included from
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:3988:
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:26:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'PerlInterpreter'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:31:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'perl_key'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:35:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:36:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:37:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:38:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:41:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:48:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'perl_mutex'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:52:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'perl_mutex'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:56:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'const'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:61:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'Sighandler_t'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:66:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'SV'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:69:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'Sighandler_t'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlvars.h:73:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4104:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4105:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4106:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4107:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4108:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4109:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4110:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4111:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4112:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4113:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4114:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4115:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4116:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4117:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4118:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4119:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4120:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4121:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4122:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4123:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4124:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4125:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4131:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4132:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4133:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4134:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4137:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4140:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4141:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4143:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4144:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'MGVTBL'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perl.h:4231:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'char'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:220:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'PERL_EXPORT_C'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:233:
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'FILE'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/perlio.h:287:
...
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:280:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:290:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:306:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:322:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:336:
error: expected '=', ',', ';', 'asm' or '__attribute__' before
'cv_flags_t'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:340:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:370:
error: expected specifier-qualifier-list before 'STRLEN'
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/sv.h:1384:
error: expected specifier-qualifier-list before 'AV'
make: *** [.o] Error 1
command failed! at /usr/local/spamassassin/bin/sa-compile line 287.
COMPILE DONE
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes for 3.2 |ok to commit
------- Additional Comments From felicity@apache.org 2007-12-30 14:46 -------
+1
>From a quick glance it looks ok. But since I didn't see an obvious reason ... why does this data have to be
sorted at all?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|sa-compile failure on latest|[review] sa-compile failure
|on OSX/Leopard |on latest on OSX/Leopard
Status Whiteboard| |needs 2 votes for 3.2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|ok to commit |needs 2 votes for 3.2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From schneecrash+apache@gmail.com 2007-12-12 07:14 -------
> (In reply to comment #2)
> this is the default install of perl on Leopard, right? (just checking)
osx' perl? that buggy thing? ;-)
of course not. i haven't used it for ages -- since b4 i ever started building
SA. instead, it's my standard own-build of perl 588:
----------------------------
Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
Platform:
osname=darwin, osvers=8.10.0, archname=darwin-thread-multi-2level
uname='darwin sc.local 8.10.0 darwin kernel version 8.10.0: wed may 23
16:50:59 pdt 2007; root:xnu-792.21.3~1release_ppc power macintosh powerpc '
config_args='-Dfirstmakefile=GNUmakefile -Dprefix=/usr/local/perl5 ...'
hint=recommended, useposix=true, d_sigaction=define
usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=undef use64bitall=undef uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags ='-fno-common -DPERL_DARWIN -no-cpp-precomp
-fno-strict-aliasing -pipe -Wdeclaration-after-statement
-I/usr/local/db46/include -I/usr/local/include',
optimize='-O3',
cppflags='-no-cpp-precomp -fno-common -DPERL_DARWIN -no-cpp-precomp
-fno-strict-aliasing -pipe -Wdeclaration-after-statement
-I/usr/local/db46/include -I/usr/local/include'
ccversion='', gccversion='4.0.1 (Apple Computer, Inc. build 5367)',
gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=4321
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='env MACOSX_DEPLOYMENT_TARGET=10.4 cc', ldflags ='-L/usr/local/db46/lib
-L/usr/local/lib -L/usr/lib'
libpth=/usr/local/db46/lib /usr/local/lib /usr/lib
libs=-ldb -lc -lm -ldl
perllibs=-lc -lm -ldl
libc=/usr/lib/libc.dylib, so=dylib, useshrplib=true, libperl=libperl.dylib
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags='-L/usr/local/db46/lib -L/usr/local/lib -L/usr/lib
-bundle -undefined dynamic_lookup'
Characteristics of this binary (from libperl):
Compile-time options: MULTIPLICITY PERL_IMPLICIT_CONTEXT
PERL_MALLOC_WRAP USE_ITHREADS USE_LARGE_FILES
USE_PERLIO USE_REENTRANT_API
Built under darwin
Compiled at Aug 17 2007 16:10:22
----------------------------
compiled, obviously, befor my leopard upgrade, while still on osx 8.10.0.
i also note,
ld='env MACOSX_DEPLOYMENT_TARGET=10.4 cc'
which, for leopard, should be
... MACOSX_DEPLOYMENT_TARGET=10.5 ...
if you think it matters (i doubt it does ...), i can rebuild.
> have you built any other perl XS modules? e.g. trying installing HTML::Parser
> using CPAN.pm: "sudo cpan HTML::Parser"
many. including 'HTML::Parser'. no problems.
e.g.,
...
Module 'HTML::Parser' installed successfully
No errors installing all modules
------- Additional Comment #2 From Justin Mason 2007-12-12 03:10 [reply] -------
(In reply to comment #2)
> could it be this?
>
>
http://arstechnica.com/journals/apple.ars/2007/12/11/fix-a-potential-cpan-gotcha-on-leopard
hm. had not seen this one.
> " ... In order to get these modules working on a 64-bit machine ..."
atm, i'm not on a 64-bit CPU; _this_box is a PPC G4 ...
but what the heck. wouldn't be the 1st time i'd seen perl-voudou at work. so,
setting
setenv ARCHFLAGS '-arch i386 -arch ppc -arch ppc64 -arch x86_64'
on my leopard box, then
sa-compile --sudo -D
the fleet of errors are still there.
given where the errors start,namely,
...
Writing Makefile for Mail::SpamAssassin::CompiledRegexps::
make
cp .pm blib/lib/.pm
cc -L/usr/local/db46/lib -L/usr/local/lib -L/usr/lib Makefile
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/EXTERN.h
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/INTERN.h ...
...
worth noting, i _now_ have darwinsource 10.5's gcc 421 installed, so that ...
which cc
/usr/bin/cc
cc -v
Using built-in specs.
Target: powerpc-apple-darwin9
Configured with: /usr/ports/gcc_42-5531/gcc_42-5531/build/obj/src/configure
--disable-checking -enable-werror --prefix=/usr --mandir=/usr/share/man
--enable-languages=c,objc,c++,obj-c++
--program-transform-name=/^[cg][^.-]*$/s/$/-4.2/
--with-gxx-include-dir=/usr/include/c++/4.0.0 --with-slibdir=/usr/lib
--build=powerpc-apple-darwin9 --host=powerpc-apple-darwin9
--target=powerpc-apple-darwin9
Thread model: posix
gcc version 4.2.1 (Apple Inc. build 5531)
is what's been invoked in the sa-compile run.
just to test, dropping back to,
gcc_select 4.0
Default compiler has been set to:
gcc version 4.0.1 (Apple Inc. build 5465)
then, again,
sa-compile --sudo -D
same errors as b4 ...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-17 01:56 -------
(In reply to comment #4)
> sort: string comparison failed: Illegal byte sequence
> sort: Set LC_ALL='C' to work around the problem.
have the patches from these bugs been applied?
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5594
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5493
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5696
I think the last one in particular may fix this.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From Mark.Martinec@ijs.si 2007-12-25 17:56 -------
> Making this completely platform independent would, I think, be done by
> requiring File::Sort. What are people's opinions as to which way is best,
> conditionalizing the code by platform, adding a new dependency for
> File::Sort, or something else I haven't thought of?
If the only problem is locale, and a system sort command works for
most common platforms, I'd prefer the system's sort.
There is a problem though with the proposed patch:
open(my $fh, "LC_ALL='C' sort $FILE |")
It requires that Perl invokes a sort through a shell,
and even more specifically, through a bourne-compatible shell.
Setting an environment variable in a Perl process, before forking
off a sort, is more portable, and avoids shell. E.g.:
{ local $ENV{LC_ALL} = "C";
open($fh, "sort |") or die "err: $!";
}
...read or whatever...
# read ruleset name from the first line in the file
my $ruleset_name;
$_ = <$fh>;
Perhaps setlocale could be used instead of env var, e.g.:
use POSIX ();
POSIX::setlocale(LC_ALL,"C");
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes for 3.2 |needs 2 votes for 3.2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2 |needs 1 votes for 3.2
------- Additional Comments From sidney@sidney.com 2007-12-26 06:18 -------
(reply to comment #16)
I didn't change it to use built-in sort because I wasn't sure abot memory usage.
Can we be sure that the rules file being sorted in small enough to slurp in and
sort? If we can, yes, that is an easy and portable change.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-26 12:47 -------
Created an attachment (id=4216)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4216&action=view)
Proposed patch to trunk that uses built in sort function
I don't think that there is enough reason to add this to 3.2 branch, so I did
not obsolete the previos patch, but here is my take on how to use the built-in
sort for trunk. My perl-fu is not that strong, so please tell me if this could
be done uaing some more typical perl idioms. I pretty much just translated the
existing code from using a sorted file to using a sorted array that is slurped
in from the file.
I did verify that sa-update runs in almost the identical amount of time before
and after this patch.
I'm still looking for one more vote for patch 4215 for 3.2 branch.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-31 07:26 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4218 is|0 |1
obsolete| |
Attachment #4219 is|0 |1
obsolete| |
------- Additional Comments From sidney@sidney.com 2007-12-31 04:11 -------
Created an attachment (id=4221)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4221&action=view)
Simple patch against 3.2 that just removes the unnecessary sort
Good catch, Theo.
Please vote on this latest patch which just removes the sort.
Committed to trunk:
svn ci -m "bug 5748: back out revs 607229 and 606874, and do much simpler fix
of removing unnecessary sort" sa-compile.raw
Sending sa-compile.raw
Transmitting file data .
Committed revision 607728.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From sidney@sidney.com 2007-12-31 10:09 -------
Committed to 3.2 branch revision 607761.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-23 13:03 -------
(In reply to comment #7)
> also fails on ubuntu as new install:
>
> # apt-get install spamassassin
> # sa-update
> # sa-compile
> * fails!
>
> # spamassassin --version
> SpamAssassin version 3.2.3
> running on Perl version 5.8.8
unless it produces the same error messages, e.g.:
/usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:106:
error: expected specifier-qualifier-list before 'CV'
I doubt it's the same issue; it might be worth taking it to the users mailing
list first. (in particular you need to apt-get install build-essential, too.)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4213 is|0 |1
obsolete| |
------- Additional Comments From sidney@sidney.com 2007-12-26 02:15 -------
Created an attachment (id=4215)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4215&action=view)
Better patch as suggested by Mark in comment #13
Thank, Mark.
Setting LC_ALL in $ENV works. I had to move the $my fh up to put it outside the
block. Doing it this way keeps the portability to what it was before, as
setting LC_ALL will just be ignored if it is not needed. Much better than the
first patch I proposed.
I like this better than adding a dependency on File::Sort.
Committed to trunk revision 606874.
I tried setlocale() already. It doesn't work. I guess that it sets the logical
environment for perl but does not actually set the environment variable that is
passed through to the shell call.
I'm calling for review and votes for 3.2.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-30 15:12 -------
(reply to comment 23)
It never occurred to me to question if the sort was necessary. The code does
require that the 'name' line come first, but the file is already written that way.
Justin appears to be the author of the original code so he might have an
explanation.
I looked at the temporary file before the call to sort and it appears to be
already sorted. It is written in sub dump_base_strings which appears to do its
own sorting. As far as I can tell there is no reason to again sort the file.
I'm going to hold off committing this until Justin pipes in with an explanation.
Perhaps the correct fix is this patch, but with the call to sort removed.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-28 03:14 -------
(In reply to comment #18)
> here is my take on how to use the built-in
> sort for trunk. My perl-fu is not that strong, so please tell me if this could
> be done uaing some more typical perl idioms. I pretty much just translated the
> existing code from using a sorted file to using a sorted array that is slurped
> in from the file.
you can replace the "$sfhindex" stuff with simpler use of "shift", but that's a
minor code-smell issue ;) looks good to me, I say check it in to trunk.
regarding the size of the input -- it's pretty small, I don't think it'd be
beyond 2MB of data in normal use. so memory-based sorting is fine.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-23 19:37 -------
Created an attachment (id=4213)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4213&action=view)
Proposed fix, patch file can be applied both to trunk and 3.2 branch
This was a surprise. The sort that was producing the error message suggesting
LC_ALL='C' is not in perl, it is a call out to the system sort program in the
open call in sub rule2xs. The fix is to change "sort $FILE |" to
"LC_ALL='C' sort $FILE |" and then sa-compile completes fine.
I'm uneasy about this because calling out to sort seems like it would be
platform dependent, and adding in the LC_ALL='C' prefix to it seems even more
so. Is sa-update only supposed to work on unix/linux platforms? Do we want to
use some pure perl sort in this place?
I haven't committed this patch to trunk yet because I would like to hear
opinions first.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-26 03:06 -------
(In reply to comment #14)
> Btw, why not set locale to C for the entire duration of
> a program (sa-compile, sa-update, spamassassin, spamd)?
> It would provide a predictable environment.
> Any reason not to?
while we don't produce any useful localized output, perl itself and
the C library may do so using LC_ALL etc., so imo it's best not
to interfere with that.
+1 on Sidney's fix for 3.2.x. I may have a look at removing the
call to "sort" entirely in trunk, since it can be
replaced with use of the sort builtin just fine. Sidney, if you
have spare tuits, feel free to investigate that yourself if you
like ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.4
------- Additional Comments From sidney@sidney.com 2007-12-23 11:58 -------
(in reply to comment #6)
I put the offending rule
body __SEEK_XMZYF9 /Original Qualit\x{e4}t - 100\% wirksam/
back in 72_active_cf, verified that bug 5594 and bug 5493 are now fixed in 3.2
branch, applied the proposed fix for bug 5696, and this problem still remains in
3.2 branch on my Mac OS 10.5.1 system
I'm setting the target to 3.2.4 because if someone comes up with a fix soon I
think we should get it in there.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From mikew@hexod.com 2007-12-23 14:34 -------
(In reply to comment #9)
> (In reply to comment #7)
> > also fails on ubuntu as new install:
> >
> > # apt-get install spamassassin
> > # sa-update
> > # sa-compile
> > * fails!
> >
> > # spamassassin --version
> > SpamAssassin version 3.2.3
> > running on Perl version 5.8.8
>
> unless it produces the same error messages, e.g.:
>
> /usr/local/lib/perl/privlib/darwin-thread-multi-2level/CORE/cop.h:106:
> error: expected specifier-qualifier-list before 'CV'
>
> I doubt it's the same issue; it might be worth taking it to the users mailing
> list first. (in particular you need to apt-get install build-essential, too.)
Yes... that was it. Sorry!!!
It sure looked similar to start with.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-12 03:10 -------
could it be this?
http://arstechnica.com/journals/apple.ars/2007/12/11/fix-a-potential-cpan-gotcha-on-leopard
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4216 is|0 |1
obsolete| |
------- Additional Comments From sidney@sidney.com 2007-12-28 05:09 -------
Created an attachment (id=4218)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4218&action=view)
Slightly cleaner patch using built in sort to avoid locale problems
(in reply to comment 19)
> you can replace the "$sfhindex" stuff with simpler use of "shift"
I did that at first, but I thought shift might mess around with the entire
array each time and wouldn't be as efficient as moving through the array with
an index.
Ok, here it is using shift.
Committed to trunk revision 607229.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2 |needs 1 votes for 3.2
------- Additional Comments From jm@jmason.org 2007-12-30 13:13 -------
(In reply to comment #21)
> Patch 4218 (built in sort) redone against 3.2 branch
+1 --much nicer ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4215 is|0 |1
obsolete| |
------- Additional Comments From sidney@sidney.com 2007-12-28 12:03 -------
Created an attachment (id=4219)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4219&action=view)
Patch 4218 (built in sort) redone against 3.2 branch
This looks so much cleaner to me that I'm going to propose that we put it in
3.2 branch also. I didn't at first out of a sense that we shouldn't change more
than we have to, but this is so much more platform independent and is simpler.
This puts us back to needing two more votes for inclusion in 3.2. Please vote.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-25 11:09 -------
sa-compile has worked under Windows, I guess because Windows has a sort file
command that is named 'sort' and does the same thing when called with just a
file argument as the *nix sort program. I doubt that this patch will work under
Windows. Making this completely platform independent would, I think, be done by
requiring File::Sort. What are people's opinions as to which way is best,
conditionalizing the code by platform, adding a new dependency for File::Sort,
or something else I haven't thought of?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2 |ready for commit
------- Additional Comments From felicity@apache.org 2007-12-31 08:16 -------
woot, I love simple things. :)
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-30 20:33 -------
Looking at the code some more, I see that a separate temporary file is created
for each priority of body rules, each file is created sorted, and we do want to
use temp files for this because there is a --keep-temp option that must be there
for a reason.
What all that seems to mean is that the correct fix for this bug is to stay with
the original code but simply change "sort $FILE |" to $FILE.
Could it be that simple?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From mikew@hexod.com 2007-12-23 10:39 -------
also fails on ubuntu as new install:
# apt-get install spamassassin
# sa-update
# sa-compile
* fails!
# spamassassin --version
SpamAssassin version 3.2.3
running on Perl version 5.8.8
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-15 16:23 -------
I should show the full error in sort, which reveals which string is causing the
problem with LC_ALL not being set to 'C':
sort: string comparison failed: Illegal byte sequence
sort: Set LC_ALL='C' to work around the problem.
sort: The strings compared were `r original qualit\344t - 100%
wirksam:__SEEK_XMZYF9,[l=1]' and `r our breakthrough casino motto is when you
win, we win! don\'t:__FRAUD_MLY,[l=1] __SEEK__DIRAB,[l=1]'.
I notice that rules/72_active.cf contains
body __SEEK_XMZYF9 /Original Qualit\x{e4}t - 100\% wirksam/
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From sidney@sidney.com 2007-12-15 15:34 -------
I noticed the following error hidden in all the debug output a little before the
start of the more obvious error messages from gcc:
sort: string comparison failed: Illegal byte sequence
sort: Set LC_ALL='C' to work around the problem.
When I use
export LC_ALL='C'
before I do sa-compile --sudo -D
Then the errors all go away. I did have to reinstall re2c because
/usr/local/bin/re2c was not migrated during my Leopard upgrade. When I
reinstalled it I used version 0.12.3, not the version 0.12.2 I had been using
with Tiger. I noticed that the release notes for 0.12.3 say that it fixes some
problems under MacOS X.
This is on a 32 bit Intel platform (first gen MacBook).
Is the correct fix to put an export LC_ALL='C' in sa-compile, or does the error
from sort indicate that we should do the export only under some circumstances?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] [review] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-31 02:50 -------
(In reply to comment #25)
> What all that seems to mean is that the correct fix for this bug is to stay with
> the original code but simply change "sort $FILE |" to $FILE.
>
> Could it be that simple?
yes ;)
rule2xs() is an adaptation of some code contributed by Matt Sergeant from a
command-line script, so it has a few vestigial features that used to be command
line switches in the original -- such as $force, and the if (!$modname) check
about 15 lines in.
Nowadays, in our code, it's only called from the rest of sa-compile, so those
command line args and input sanitizations are redundant (and should be
refactored out at some stage). Looking at it now, I can see that -- yes -- that
sort(1) invocation was also redundant, since all the input is in the correct
order already.
so go for it ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From Mark.Martinec@ijs.si 2007-12-25 18:39 -------
Forgot the filename, should be: "sort $FILE |".
Btw, why not set locale to C for the entire duration of
a program (sa-compile, sa-update, spamassassin, spamd)?
It would provide a predictable environment.
Any reason not to?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5748] sa-compile failure on latest on OSX/Leopard
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From jm@jmason.org 2007-12-12 01:31 -------
this is the default install of perl on Leopard, right? (just checking)
have you built any other perl XS modules? e.g. trying installing HTML::Parser
using CPAN.pm: "sudo cpan HTML::Parser"
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.