You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2025/11/29 19:04:10 UTC

[PR] Ofbiz-13322 removed useless collections [ofbiz-framework]

dk2k opened a new pull request, #928:
URL: https://github.com/apache/ofbiz-framework/pull/928

   Improved:
   Implemented:
   Documented:
   Completed:
   Reverted:
   Fixed:
   (OFBIZ-13322)
   
   Explanation
   
   Thanks:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Ofbiz-13322 removed useless collections [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.

JacquesLeRoux commented on PR #928:
URL: https://github.com/apache/ofbiz-framework/pull/928#issuecomment-3592425449

   Hi @dk2k,
   
   I agree that all these removing make sense. But I prefer to keep them even if they are currently indeed useless. I can't believe that these codes have been added without reason. They are all pre-Apache era. Maybe some have been incorrectly modified before. And maybe at some point someone will detect that. That's why I prefer to keep, they don't hurt and could maybe useful in future, even if very improbably.
   
   If you disagree, please start a thread on OFBiz dev ML dev@ofbiz.apache.org. Else please close this PR.
   
   Thanks for all your work so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Ofbiz-13322 removed useless collections [ofbiz-framework]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #928:
URL: https://github.com/apache/ofbiz-framework/pull/928#issuecomment-3591874329

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=928) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=928&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=928&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=928&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=928&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=928&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=928)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Ofbiz-13322 removed useless collections [ofbiz-framework]

Posted by "dk2k (via GitHub)" <gi...@apache.org>.

dk2k commented on PR #928:
URL: https://github.com/apache/ofbiz-framework/pull/928#issuecomment-3592624507

   @JacquesLeRoux I understand. I will keep this PR open for some time. And even if I close it, you can use it later as a bug report.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Ofbiz-13322 removed useless collections [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.

JacquesLeRoux commented on PR #928:
URL: https://github.com/apache/ofbiz-framework/pull/928#issuecomment-3593004103

   OK, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Ofbiz-13322 removed useless collections [ofbiz-framework]

Posted by "dk2k (via GitHub)" <gi...@apache.org>.

dk2k closed pull request #928: Ofbiz-13322 removed useless collections
URL: https://github.com/apache/ofbiz-framework/pull/928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org