You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/04 12:50:22 UTC
[GitHub] [incubator-hudi] wangxianghu opened a new pull request #1183:
[HUDI-460] Redo hudi-integ-test log statements using SLF4J
wangxianghu opened a new pull request #1183: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183
## What is the purpose of the pull request
*Redo hudi-integ-test log statements using SLF4J*
## Brief change log
*Redo hudi-integ-test log statements using SLF4J*
## Verify this pull request
This pull request should be covered by existing tests.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1183:
[HUDI-460] Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1183: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183#discussion_r363302955
##########
File path: hudi-integ-test/pom.xml
##########
@@ -63,6 +63,10 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
Review comment:
missing version? `>${slf4j.version}` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1183:
[HUDI-460] Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1183: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183#discussion_r363303802
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -239,9 +239,9 @@ private void saveUpLogs() {
executeCommandStringInDocker(HIVESERVER, "cat /tmp/root/hive.log", true).getStdout().toString();
String filePath = System.getProperty("java.io.tmpdir") + "/" + System.currentTimeMillis() + "-hive.log";
FileIOUtils.writeStringToFile(hiveLogStr, filePath);
- LOG.info("Hive log saved up at : " + filePath);
+ LOG.info("Hive log saved up at : {}", filePath);
} catch (Exception e) {
- LOG.error("Unable to save up logs..", e);
+ LOG.error("Unable to save up logs.. {}", e);
Review comment:
could use `LOG.error("Unable to save up logs.", e);` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on issue #1183: [HUDI-460]
Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on issue #1183: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183#issuecomment-571400738
Hi @leesf, Thanks for your advice, i will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf merged pull request #1183: [HUDI-460] Redo
hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1183: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1183:
[HUDI-460] Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1183: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183#discussion_r363304308
##########
File path: pom.xml
##########
@@ -397,6 +397,11 @@
<artifactId>log4j</artifactId>
<version>${log4j.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>${slf4j.version}</version>
+ </dependency>
Review comment:
could be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services