[GitHub] [hbase] virajjasani commented on a change in pull request #3606: HBASE-25815 RSGroupBasedLoadBalancer online status never updates after being set to true for the first time

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #3606:
URL: https://github.com/apache/hbase/pull/3606#discussion_r760965621



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -661,12 +663,14 @@ private synchronized void flushConfig(Map<String, RSGroupInfo> newGroupMap) thro
       return;
     }
 
+    // Make changes visible

Review comment:
       @caroliney14 even if we don't change this order, are we still good with the main problem? I was wondering if this particular order of in-memory vs persistent update could be taken up in follow-up PR as well if we are good with the latest change in `isOnline()` method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org