You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/23 13:56:21 UTC
[GitHub] [calcite] dawidwys opened a new pull request #2042: [CALCITE-4085] Improve nullability support for fields of structured type
dawidwys opened a new pull request #2042:
URL: https://github.com/apache/calcite/pull/2042
This PR tries to improve nullability of records fields when the record itself is nullable,
The PR is split into three commits which in my opinion affect the code base to a different extent. Calcite users should not see a difference in the behaviour, but downstream projects that depend on Calcite can implement a support for not null fields within a nullable record type based on those changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on pull request #2042: [CALCITE-4085] Improve nullability support for fields of structured types
Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2042:
URL: https://github.com/apache/calcite/pull/2042#issuecomment-657400859
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] dawidwys commented on pull request #2042: [CALCITE-4085] Improve nullability support for fields of structured types
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #2042:
URL: https://github.com/apache/calcite/pull/2042#issuecomment-650017811
Do you mind having a look @danny0405 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 closed pull request #2042: [CALCITE-4085] Improve nullability support for fields of structured types
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #2042:
URL: https://github.com/apache/calcite/pull/2042
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org