You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/07 11:36:04 UTC

[GitHub] [tvm] srkreddy1238 opened a new pull request, #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

srkreddy1238 opened a new pull request, #13307:
URL: https://github.com/apache/tvm/pull/13307

   Not all plarforms 64bit aligned allocations. Platforms with 32bit alignment fail to support set_input_zero_copy even though the ndarray is allocated by the tvm runtime itself.
   
   This change enabled configurable option for such targets.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13307:
URL: https://github.com/apache/tvm/pull/13307#issuecomment-1305477133

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @areusch <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

Posted by GitBox <gi...@apache.org>.
junrushao merged PR #13307:
URL: https://github.com/apache/tvm/pull/13307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] srkreddy1238 commented on pull request #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

Posted by GitBox <gi...@apache.org>.
srkreddy1238 commented on PR #13307:
URL: https://github.com/apache/tvm/pull/13307#issuecomment-1315229497

   cc @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on a diff in pull request #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #13307:
URL: https://github.com/apache/tvm/pull/13307#discussion_r1019833118


##########
CMakeLists.txt:
##########
@@ -463,6 +463,11 @@ if(USE_PIPELINE_EXECUTOR)
   list(APPEND RUNTIME_SRCS ${RUNTIME_PIPELINE_SRCS})
 endif(USE_PIPELINE_EXECUTOR)
 
+if(USE_KALLOC_ALIGNMENT)
+  message(STATUS "Build Alloc alignment set to ${USE_KALLOC_ALIGNMENT}")
+  add_definitions(-DKALLOC_ALIGNMENT=${USE_KALLOC_ALIGNMENT})

Review Comment:
   How about prefix the. macro with `TVM_`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on a diff in pull request #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #13307:
URL: https://github.com/apache/tvm/pull/13307#discussion_r1019833326


##########
include/tvm/runtime/device_api.h:
##########
@@ -51,11 +51,19 @@ enum DeviceAttrKind : int {
   kDriverVersion = 12
 };
 
+#ifdef KALLOC_ALIGNMENT

Review Comment:
   like:
   
   ```suggestion
   #ifdef TVM_ALLOC_ALIGNMENT
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #13307: [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13307:
URL: https://github.com/apache/tvm/pull/13307#issuecomment-1315659726

   Thanks @srkreddy1238 for the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org