You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/25 09:23:29 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1984: feat: add new route matching param position

juzhiyuan commented on a change in pull request #1984:
URL: https://github.com/apache/apisix-dashboard/pull/1984#discussion_r676114846



##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -104,6 +104,9 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
           case 'cookie':
             renderText = 'Cookie';
             break;
+          case 'buildin':

Review comment:
       Hi, usually we will call it `builtin`, could you please provide a link on this param?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org