You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/05/11 02:05:00 UTC

Review Request: OOZIE-834 Testcases for MapReduceMain, StreamingMain, PigMain, HiveMain fail with Hadoop 2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5090/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

Hadoop 2 changed it's minicluster to use random ports recently.

The testcases for the MR/Streaming/Pig/Hive Main classes are not being configured correctly with the minicluster configuration thus are taking incorrect ports and fail.


This addresses bug OOZIE-834.
    https://issues.apache.org/jira/browse/OOZIE-834


Diffs
-----

  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1336960 

Diff: https://reviews.apache.org/r/5090/diff


Testing
-------

run successfully the affected tests with Hadoop 1 and Hadoop 2 (except for the TestPigMain & TestHiveMain because there are not JARs for hadoop 2 avail in maven repo)


Thanks,

Alejandro


Re: Review Request: OOZIE-834 Testcases for MapReduceMain, StreamingMain, PigMain, HiveMain fail with Hadoop 2

Posted by Alejandro Abdelnur <tu...@cloudera.com>.

> On 2012-05-11 19:38:05, Mohammad Islam wrote:
> > +1
> > how the unavailable maven repo will be resolved in the long run.

it is up to pig and hive teams to take care o that, for pig i opened a jira


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5090/#review7812
-----------------------------------------------------------


On 2012-05-11 16:07:07, Alejandro Abdelnur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5090/
> -----------------------------------------------------------
> 
> (Updated 2012-05-11 16:07:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Hadoop 2 changed it's minicluster to use random ports recently.
> 
> The testcases for the MR/Streaming/Pig/Hive Main classes are not being configured correctly with the minicluster configuration thus are taking incorrect ports and fail.
> 
> 
> This addresses bug OOZIE-834.
>     https://issues.apache.org/jira/browse/OOZIE-834
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1336960 
> 
> Diff: https://reviews.apache.org/r/5090/diff
> 
> 
> Testing
> -------
> 
> run successfully the affected tests with Hadoop 1 and Hadoop 2 (except for the TestPigMain & TestHiveMain because there are not JARs for hadoop 2 avail in maven repo)
> 
> 
> Thanks,
> 
> Alejandro
> 
>


Re: Review Request: OOZIE-834 Testcases for MapReduceMain, StreamingMain, PigMain, HiveMain fail with Hadoop 2

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5090/#review7812
-----------------------------------------------------------

Ship it!


+1
how the unavailable maven repo will be resolved in the long run.

- Mohammad


On 2012-05-11 16:07:07, Alejandro Abdelnur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5090/
> -----------------------------------------------------------
> 
> (Updated 2012-05-11 16:07:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Hadoop 2 changed it's minicluster to use random ports recently.
> 
> The testcases for the MR/Streaming/Pig/Hive Main classes are not being configured correctly with the minicluster configuration thus are taking incorrect ports and fail.
> 
> 
> This addresses bug OOZIE-834.
>     https://issues.apache.org/jira/browse/OOZIE-834
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1336960 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1336960 
> 
> Diff: https://reviews.apache.org/r/5090/diff
> 
> 
> Testing
> -------
> 
> run successfully the affected tests with Hadoop 1 and Hadoop 2 (except for the TestPigMain & TestHiveMain because there are not JARs for hadoop 2 avail in maven repo)
> 
> 
> Thanks,
> 
> Alejandro
> 
>


Re: Review Request: OOZIE-834 Testcases for MapReduceMain, StreamingMain, PigMain, HiveMain fail with Hadoop 2

Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5090/
-----------------------------------------------------------

(Updated 2012-05-11 16:07:07.900173)


Review request for oozie.


Changes
-------

adding fix for TestPipesMain which I've missed before


Summary
-------

Hadoop 2 changed it's minicluster to use random ports recently.

The testcases for the MR/Streaming/Pig/Hive Main classes are not being configured correctly with the minicluster configuration thus are taking incorrect ports and fail.


This addresses bug OOZIE-834.
    https://issues.apache.org/jira/browse/OOZIE-834


Diffs (updated)
-----

  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1336960 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1336960 

Diff: https://reviews.apache.org/r/5090/diff


Testing
-------

run successfully the affected tests with Hadoop 1 and Hadoop 2 (except for the TestPigMain & TestHiveMain because there are not JARs for hadoop 2 avail in maven repo)


Thanks,

Alejandro