rebase and retest on github

[Benjamin Reed <br...@apache.org>]

i would really like to get ZOOKEEPER-3922 but it needs to be rebased
and retested. is there a nice way to do that on github? or does the
pull requestor need to do that?

happy new year,
ben

Re: rebase and retest on github

[Enrico Olivelli <eo...@gmail.com>]

I think it is better to ask the contributor to perform the rebase and push.

As you have write access you can push to the branch of the contributor, but
I am not sure this is a good approach.

If a patch is stale and the developer stopped working on it then you can
pick up that work, create a new branch and a new PR,
paying much attention in keeping the right references to the original
author of the work.

Enrico

Il giorno ven 29 gen 2021 alle ore 08:50 Flavio Junqueira <fp...@apache.org>
ha scritto:

> I do it from the command line and push. You can do it from an IDE too, but
> I'm not aware of a way of doing it directly on GitHub.
>
> -Flavio
>
> > On 29 Jan 2021, at 07:34, Benjamin Reed <br...@apache.org> wrote:
> >
> > i would really like to get ZOOKEEPER-3922 but it needs to be rebased
> > and retested. is there a nice way to do that on github? or does the
> > pull requestor need to do that?
> >
> > happy new year,
> > ben
>
>

Re: rebase and retest on github

[Flavio Junqueira <fp...@apache.org>]

I do it from the command line and push. You can do it from an IDE too, but I'm not aware of a way of doing it directly on GitHub.

-Flavio

> On 29 Jan 2021, at 07:34, Benjamin Reed <br...@apache.org> wrote:
> 
> i would really like to get ZOOKEEPER-3922 but it needs to be rebased
> and retested. is there a nice way to do that on github? or does the
> pull requestor need to do that?
> 
> happy new year,
> ben