[jira] [Commented] (HADOOP-11505) Various native parts use bswap incorrectly and unportably

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195804#comment-15195804 ] 

Colin Patrick McCabe commented on HADOOP-11505:
-----------------------------------------------

Hi [~alanburlison],

Thanks for persisting with this.  As per the comments earlier, it's kind of unpleasant to add a dependency on a header generated in hadoop-common when we don't have to.  It seems like we can avoid this problem just by putting the {{configure_file}} statement in the {{hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt}} file.  (Of course the actual {{hadoop_endian.h.cmake}} file can continue to be in hadoop-common if you like.)

> Various native parts use bswap incorrectly and unportably
> ---------------------------------------------------------
>
>                 Key: HADOOP-11505
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11505
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Alan Burlison
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-11505.001.patch, HADOOP-11505.003.patch, HADOOP-11505.004.patch, HADOOP-11505.005.patch, HADOOP-11505.006.patch, HADOOP-11505.007.patch, HADOOP-11505.008.patch
>
>
> hadoop-mapreduce-client-nativetask fails to use x86 optimizations in some cases.  Also, on some alternate, non-x86, non-ARM architectures the generated code is incorrect.  Thanks to Steve Loughran and Edward Nevill for finding this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)