You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by sectioneight <gi...@git.apache.org> on 2014/12/17 01:38:58 UTC
[GitHub] thrift pull request: THRIFT-2900 Wrap Python THttpClient withTimeo...
GitHub user sectioneight opened a pull request:
https://github.com/apache/thrift/pull/322
THRIFT-2900 Wrap Python THttpClient withTimeout in a try/finally
Otherwise the original value of the socket timeout is not restored
properly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sectioneight/thrift THRIFT-2900
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit a8ee0b14e943a1faf32bd20378a0784175ba6a00
Author: Aiden Scandella <ai...@uber.com>
Date: 2014-12-17T00:37:06Z
Wrap THttpClient withTimeout in a try/finally
Otherwise the original value of the socket timeout is not restored
properly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2900 Wrap Python THttpClient withTimeo...
Posted by breerly <gi...@git.apache.org>.
Github user breerly commented on the pull request:
https://github.com/apache/thrift/pull/322#issuecomment-67260174
+1 - this checks out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2900 Wrap Python THttpClient withTimeo...
Posted by breerly <gi...@git.apache.org>.
Github user breerly commented on the pull request:
https://github.com/apache/thrift/pull/322#issuecomment-68663918
@sectioneight looks like the build failed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2900 Wrap Python THttpClient withTimeo...
Posted by sectioneight <gi...@git.apache.org>.
Github user sectioneight commented on the pull request:
https://github.com/apache/thrift/pull/322#issuecomment-68711033
Indeed it did. Seems to be unrelated...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2900 Wrap Python THttpClient withTimeo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---