You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2017/11/17 14:50:27 UTC
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/1525
[CARBONDATA-1751] Make the type of exception and message correctly
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
change old test cases to adapt changed massage
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
MR55
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata msgYaDong
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1525
----
commit 80ea7c95b00680c43fd8d16f5aa51a30311a8930
Author: xubo245 <60...@qq.com>
Date: 2017-11-17T14:36:46Z
[CARBONDATA-1751] Make the type of exception and message correctly
----
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1525
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1779/
---
[GitHub] carbondata issue #1525: [WIP][CARBONDATA-1751] Make the type of exception an...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1255/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1284/
---
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1525
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1302/
---
[GitHub] carbondata issue #1525: [WIP][CARBONDATA-1751] Make the type of exception an...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1256/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1525
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1771/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1525
LGTM
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1525
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1773/
---
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
Posted by chenerlu <gi...@git.apache.org>.
Github user chenerlu commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1525#discussion_r151911286
--- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
@@ -18,12 +18,10 @@
package org.apache.spark.carbondata
import scala.collection.mutable
-
--- End diff --
Suggest keep this space line
---
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
Posted by chenerlu <gi...@git.apache.org>.
Github user chenerlu commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1525#discussion_r151911377
--- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
@@ -18,12 +18,10 @@
package org.apache.spark.carbondata
import scala.collection.mutable
-
import org.apache.spark.sql.common.util.Spark2QueryTest
import org.apache.spark.sql.types._
-import org.apache.spark.sql.{Row, SaveMode}
+import org.apache.spark.sql.{AnalysisException, Row, SaveMode}
import org.scalatest.BeforeAndAfterAll
-
--- End diff --
Suggest keep this space line
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1525
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1772/
---
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1525#discussion_r151912584
--- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
@@ -18,12 +18,10 @@
package org.apache.spark.carbondata
import scala.collection.mutable
-
import org.apache.spark.sql.common.util.Spark2QueryTest
import org.apache.spark.sql.types._
-import org.apache.spark.sql.{Row, SaveMode}
+import org.apache.spark.sql.{AnalysisException, Row, SaveMode}
import org.scalatest.BeforeAndAfterAll
-
--- End diff --
OK, Done
---
[GitHub] carbondata issue #1525: [WIP][CARBONDATA-1751] Make the type of exception an...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1258/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1525
I have fixed conflicts, please review it @jackylk
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1306/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1235/
---
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1525#discussion_r151912577
--- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
@@ -18,12 +18,10 @@
package org.apache.spark.carbondata
import scala.collection.mutable
-
--- End diff --
OK, Done
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1283/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1525
Please review it @jackylk
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1268/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1525
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1265/
---
[GitHub] carbondata issue #1525: [CARBONDATA-1751] Make the type of exception and mes...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1525
Erlu Chen and Yadong Qi have reivewed this PR, please review it again @jackylk
---
[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1525#discussion_r151831251
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/AlterTableCompactionCommand.scala ---
@@ -87,8 +88,10 @@ case class AlterTableCompactionCommand(
} catch {
case e: Exception =>
if (null != e.getMessage) {
+ // TODO: We should modify it when we support compaction later.
sys.error(s"Compaction failed. Please check logs for more info. ${ e.getMessage }")
--- End diff --
Why not change this also?
---