[GitHub] [lucenenet] theolivenbaum commented on pull request #371: Add new interface to NumericDocValues to close #370

[GitBox <gi...@apache.org>]

theolivenbaum commented on pull request #371:
URL: https://github.com/apache/lucenenet/pull/371#issuecomment-724121424


   Hi @NightOwl888 - sorry for the long time since my last answer - but I was off last week on long due holidays :)
   
   I think this change is significant for our usage of Lucene, but probably is not captured by the benchmark as they only enumerate some results. 
   
   On our use-case, we often need to enumerate all hits up to a limit (usually hundreds of thousands) - and read the value of an identifier field to match with our data for further processing - which is what causes the large number of calls to this method. I can try to push a new benchmark to reflect that, but measuring locally running our code directly referencing the Lucene projects instead of the nuget package gave us a significant reduction in allocations.
   
   
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org