You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/24 15:30:34 UTC

[GitHub] [helix] narendly opened a new issue #1403: Update the JavaDoc on ZkClientType

narendly opened a new issue #1403:
URL: https://github.com/apache/helix/issues/1403


   ### Describe the bug
   ```
       /**
        * When ZkBaseDataAccessor is created with the DEDICATED type, it supports ephemeral node
        * creation, callback functionality, and session management. But note that this is more
        * resource-heavy since it creates a dedicated ZK connection so should be used sparingly only
        * when the aforementioned features are needed.
        */
       DEDICATED,
   
       /**
        * When ZkBaseDataAccessor is created with the SHARED type, it only supports CRUD
        * functionalities. This will be the default mode of creation.
        */
       SHARED,
   ```
   The Javadoc says SHARED only supports CRUD, but it actually also supports change subscription. This needs to be updated.
   
   ### To Reproduce
   -
   
   ### Expected behavior
   -
   
   ### Additional context
   -
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org