You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by dj...@apache.org on 2006/09/20 22:56:55 UTC
svn commit: r448338 - in
/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql:
compile/DistinctNode.java compile/FromBaseTable.java
compile/GroupByNode.java compile/OrderByList.java
execute/MergeJoinResultSet.java
Author: djd
Date: Wed Sep 20 13:56:54 2006
New Revision: 448338
URL: http://svn.apache.org/viewvc?view=rev&rev=448338
Log:
DERBY-1700 Cleanup some remaining comments that referred to closeCleanup parameters and
a parameter reference in the unused class MergeJoinResultSet.
Modified:
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/DistinctNode.java
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OrderByList.java
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/MergeJoinResultSet.java
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/DistinctNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/DistinctNode.java?view=diff&rev=448338&r1=448337&r2=448338
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/DistinctNode.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/DistinctNode.java Wed Sep 20 13:56:54 2006
@@ -324,7 +324,6 @@
* from the sort
* arg6: row size
* arg7: resultSetNumber
- * arg8: closeCleanup
*/
acb.pushGetResultSetFactoryExpression(mb);
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java?view=diff&rev=448338&r1=448337&r2=448338
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java Wed Sep 20 13:56:54 2006
@@ -3143,7 +3143,6 @@
** isolationLevel,
** optimizerEstimatedRowCount,
** optimizerEstimatedRowCost,
- ** closeCleanupMethod
** );
*/
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java?view=diff&rev=448338&r1=448337&r2=448338
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java Wed Sep 20 13:56:54 2006
@@ -934,7 +934,6 @@
* from the sort
* arg7: row size
* arg8: resultSetNumber
- * arg11: closeCleanup
*/
String resultSet = (addDistinctAggregate) ? "getDistinctGroupedAggregateResultSet" : "getGroupedAggregateResultSet";
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OrderByList.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OrderByList.java?view=diff&rev=448338&r1=448337&r2=448338
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OrderByList.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OrderByList.java Wed Sep 20 13:56:54 2006
@@ -371,7 +371,6 @@
* arg7: resultSetNumber
* arg8: estimated row count
* arg9: estimated cost
- * arg10: closeCleanup
*/
acb.pushGetResultSetFactoryExpression(mb);
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/MergeJoinResultSet.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/MergeJoinResultSet.java?view=diff&rev=448338&r1=448337&r2=448338
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/MergeJoinResultSet.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/MergeJoinResultSet.java Wed Sep 20 13:56:54 2006
@@ -75,7 +75,6 @@
* @param oneRowRightSide ignored
* @param optimizerEstimatedRowCount self-explanatory
* @param optimizerEstimatedCost self-explanatory
- * @param closeCleanup self-explanatory
*/
MergeJoinResultSet(NoPutResultSet leftResultSet,
int leftNumCols,
@@ -88,8 +87,7 @@
boolean oneRowRightSide,
boolean notExistsRightSide,
double optimizerEstimatedRowCount,
- double optimizerEstimatedCost,
- GeneratedMethod closeCleanup)
+ double optimizerEstimatedCost)
{
super(leftResultSet, leftNumCols, rightResultSet, rightNumCols,
activation, restriction, resultSetNumber,