You are viewing a plain text version of this content. The canonical link for it is here.

Posted to yarn-issues@hadoop.apache.org by "Denes Gerencser (Jira)" <ji...@apache.org> on 2019/09/26 11:29:00 UTC

[jira] [Assigned] (YARN-9362) Code cleanup in TestNMLeveldbStateStoreService

     [ https://issues.apache.org/jira/browse/YARN-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denes Gerencser reassigned YARN-9362:
-------------------------------------

    Assignee: Denes Gerencser

> Code cleanup in TestNMLeveldbStateStoreService
> ----------------------------------------------
>
>                 Key: YARN-9362
>                 URL: https://issues.apache.org/jira/browse/YARN-9362
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Denes Gerencser
>            Priority: Minor
>
> There are many ways to improve TestNMLeveldbStateStoreService: 
> 1. RecoveredContainerState fields are asserted many times repeatedly. Some simple method extractions would definitely make this more readable.
> 2. The tests are very long and hard to read in general: Again, finding how methods could be extracted to avoid code repetition could help. 
> 3. You name it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org