You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/01/25 18:35:07 UTC
[GitHub] [helix] NealSun96 opened a new issue #1941: Error partition logging is not in effect
NealSun96 opened a new issue #1941:
URL: https://github.com/apache/helix/issues/1941
### Describe the bug
Error partition logging in IntermediateStateCalcStage does not work since the if condition is always false.
### To Reproduce
The logging is absent with error partitions.
### Expected behavior
The logging should work correctly when there are error partitions.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 closed issue #1941: Error partition logging is not in effect
Posted by GitBox <gi...@apache.org>.
NealSun96 closed issue #1941:
URL: https://github.com/apache/helix/issues/1941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on issue #1941: Error partition logging is not in effect
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on issue #1941:
URL: https://github.com/apache/helix/issues/1941#issuecomment-1021530559
```
if (!partitionsWithErrorStateReplica.isEmpty()) {
LogUtil.logInfo(logger, _eventId,
String.format("Partition currently has an ERROR replica in %s partitions: %s",
resourceName, partitionsWithErrorStateReplica));
}
```
This if condition is always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #1941: Error partition logging is not in effect
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #1941:
URL: https://github.com/apache/helix/issues/1941#issuecomment-1021506328
Could you please provide more information, like a code snapshot, to clarify the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org