[GitHub] [ignite] timoninmaxim commented on a change in pull request #9837: IGNITE-16103: temporary PR for some questions

[GitBox <gi...@apache.org>]

timoninmaxim commented on a change in pull request #9837:
URL: https://github.com/apache/ignite/pull/9837#discussion_r823574265



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/sql/SqlKeyword.java
##########
@@ -347,7 +348,11 @@
      * @return {@code True} if it is a keyword.
      */
     public static boolean isKeyword(String str) {
-        return KEYWORDS.contains(str);
+        boolean isFallback = IgniteSystemProperties.getBoolean(IgniteSystemProperties.IGNITE_SQL_PARSER_DISABLE_H2_FALLBACK);

Review comment:
       It looks like we should skip check for keyword for some circumstances: for example in case of creating index we know that the next token is table name and we should not validate it. See`SqlCreateIndexCommand`:
   
   `SqlQualifiedName tblQName = parseQualifiedIdentifier(lex);`
   
   I think we should provide a special flag here that will skip the validation for table name.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org